Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Send Notification with Login ActionBlock When User Not logged In #47

Open
1 task
Nabhag8848 opened this issue Feb 15, 2023 · 4 comments · May be fixed by #80
Open
1 task

[FEAT] Send Notification with Login ActionBlock When User Not logged In #47

Nabhag8848 opened this issue Feb 15, 2023 · 4 comments · May be fixed by #80
Labels
enhancement New feature or request

Comments

@Nabhag8848
Copy link
Contributor

Nabhag8848 commented Feb 15, 2023

Why do we need this ?

As a GitHub App developer

I need to:

  • Alter/Add Extra information to the Block Notification Send when user runs commands (list mentioned) which needs authentication while not being loggedin.

Command List:

- View your GitHub Profile and Issues -> /github me
- View/Add/Delete/Update Repository Subscriptions -> /github subscribe
- Subscribe to all repository events -> /github Username/RepositoryName subscribe
- Unsubscribe to all repository events -> /github Username/RepositoryName unsubscribe
- Add New Issues to GitHub Repository -> /github issue
- Assign and Share Issues -> /github issues
  • So Currently when we run above command for eg for subscribing events we get Notification that Login to subscribe to repository events ! /github login but what we want is and will more helpful: We send Login ActionButton attaching to that same Block while having the Message You must be LoggedIn to subscribe repository events. Login to Github.

So That: We will save the key strokes for users to not run command /github login

Glimpses of what should look like:

LoginFeatExtend

Acceptance Criteria

  • Alter and Add to same Notify Block with LoginButtons for all commands mention

Further Comments / References

  • Also to Note we will have different messages the one that i mention was just for the subscribe event.
  • To note we also have ActionsButtons within Modal which needs authentications dont forget to look for same.

Additional comments

  • Apart from that we have one know bug (when writing this issue): When we run /github Username/RepositoryName subscribe without loggedin we ain't getting any message if we are not loggedIn. which has/ have been fixed [FIX] subscribeall doesn't provide info when not loggedIn #63. which currently provides the simple loginInfo make sure to change it when merging this.
@Nabhag8848
Copy link
Contributor Author

Hey, @samad-yar-khan can you have a look at this, do we need this feat?

@samad-yar-khan
Copy link
Collaborator

Hey @Nabhag8848 Seems like a good thing to have ! thanks for pointing this suggestion

@Nabhag8848
Copy link
Contributor Author

Nabhag8848 commented Mar 14, 2023

Note:

@Prince-Mendiratta
Copy link
Contributor

Hiya again @Nabhag8848 @samad-yar-khan! Created a PR to fix this issue, kindly review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants