[FIX] Description Under Overview Action Showing null #39
Conversation
There was a problem hiding this comment.
@Nabhag8848 Thanks for your PR 🚀 Added some suggestions, can you please take a look ?
github/lib/repoDataMessage.ts
Outdated
| let description: string | null = resData.description; | ||
|
|
||
| if(description === null){ | ||
| description = 'No description provided.'; | ||
| } | ||
|
|
There was a problem hiding this comment.
Hey @Nabhag8848 , thanks for solving this for us. Works well 🚀 !
But maybe we can do something like this
const description = resData.description || 'No description provided.';
This will make sure that the description is const and is not updated before sending it to the main channel. Also it fits with the code style we have in this file and saves some lines.
There was a problem hiding this comment.
@Nabhag8848 Can this PR be extended to fix some other places where we are showing null values ?
There was a problem hiding this comment.
Yep! we can do that. Do you encounter any nulls, possibly i didn't encounter yet? if you have point me up.
There was a problem hiding this comment.
Hey, @samad-yar-khan . I found lot of places where there is asyncronous operation without await and vice versa. should i make the commits within this PR? also we can merge my PR #41 branch with this one to make it bigger or we will include issue #47 within PR #41 later.
How should we proceed.
|
@Nabhag8848 Can you please remove the last commit and make a separate Issue / PR to explain the position if |
Nabhag8848
force-pushed
the
repo-overview
branch
from
f7c9ab0
to
3a3d7b3
Compare
Thanks @samad-yar-khan and thanks for pointing out. done removing the same and learn the lesson, i should not commit changes without acknowledgement. |
|
@Nabhag8848 LGTM ! you can add the |
Issue(s)
Closes #38
Fixed Bugs
No description providedtext instead ofnullwhen the repository doesn't have a description.