Using unsupported options causes a load error due to missing variable

[johnathanludwig]

Adding an option to attr_encrypted that is not supported by Symmetric Encryption causes an exception due to the params variable not being passed to the warn.

I've set the variable to be passed and added a test to confirm. Having the unsupported option present is all that is really needed to test as it prevents load, but I've added an explicit test so it will be clear why it is there in future changes.

I discovered this when using the gem tinfoil/devise-two-factor. This gem uses attr_encrypted's :key and :mode options here.

[reidmorrison]

Nice tests. I would prefer to just remove the params option altogether on the call to warn. This method was extracted from duplicated code for MySQL and Mongo. params is only available in the MySQL attr_encrypted call.

The other usage of params.inspect on the raise call can be changed to options.inspect.

[johnathanludwig]

Alright, removed. I was thinking the same thing, 5 method parameters is a lot.

I didn't add options.inspect to the warn as it is already looping through options and warning on the leftovers individually.

[reidmorrison]

Thank you Johnathan. This issue would definitely hamper new adopters and the tests are most welcome.