Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the extractor to allow union types on models #111

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Update the extractor to allow union types on models #111

merged 3 commits into from
Apr 21, 2023

Conversation

rockneurotiko
Copy link
Owner

Fix #110

@rockneurotiko rockneurotiko mentioned this pull request Mar 21, 2023
Closed
@a3kov
Copy link

a3kov commented Apr 12, 2023

I am thinking it's not as simple as that. This only updates the extractor. Don't you also need to update the macro helpers ?

@rockneurotiko
Copy link
Owner Author

I don't think so, the macros are generating the structs correctly with the union types:

image

@rockneurotiko rockneurotiko merged commit c89cb36 into master Apr 21, 2023
@rockneurotiko rockneurotiko deleted the models_fields_many_types branch April 21, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some complex types are incorrect
2 participants
@rockneurotiko @a3kov