Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC Telemetry #97

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Ironjanowar
Copy link
Collaborator

No description provided.

@Ironjanowar
Copy link
Collaborator Author

Example of bot using Telemetry

Ironjanowar/meme_bot#2

@Ironjanowar Ironjanowar marked this pull request as ready for review December 18, 2022 20:50

cnt ->
info = extract_info(cnt)
spawn(fn -> call_handler(handler, info, cnt, error_handler) end)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the handlers executed with spawn are not being reported correctly 🤔
The easy solution would be to add another span on the call_handler

@prtngn
Copy link
Contributor

prtngn commented Mar 24, 2023

What about these revisions? What needs to be done for them to be merged into the master branch?

@Ironjanowar
Copy link
Collaborator Author

Hi! @prtngn I'm waiting for #95 to be merged in master. And probably start from there.

I also wanted to create a macro or use some kind of decorator to avoid wrapping every function in the dispatcher with a with_span function.

Either way, I'm currently working in other projects in my free time so I don't know when I will come back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants