Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 32-bit unsigned integer UID's for GoogleOTP #10

Open
tcooper opened this issue Oct 4, 2014 · 2 comments
Open

Support 32-bit unsigned integer UID's for GoogleOTP #10

tcooper opened this issue Oct 4, 2014 · 2 comments

Comments

@tcooper
Copy link
Contributor

tcooper commented Oct 4, 2014

The following lines of plugin_googleotp.py 411 plugin...

                # only users in Range
                if uid >= 500 and uid < 65534: 
                    otp_users.append(username)

...limit googleotp to user accounts with UID's below the old maximum value (an unsigned 16-bit integer).

Newer kernels use an unsigned 32-bit integer for the UID and GID.

Perhaps we could allow UID values up to the current max (4294967294) to use googleotp out of the box.

@lclementi
Copy link
Contributor

Yea but Centos limit the uid to:
[root@rocks-152 google-otp]# grep UID /etc/login.defs
UID_MIN 500
UID_MAX 60000

Is there a specific reason why we need this?

Luca

@tcooper
Copy link
Contributor Author

tcooper commented Feb 4, 2015

While /etc/login.defs defines the default values for UID_[MIN|MAX] and SYS_UID_[MIN|MAX] the data type holding these values supports larger UID values and, in fact, larger UID values are used.

The change is not required but would add support for GoogleOTP for UID values larger than 65535 if they were, in fact, in use.

It's a feature request not a bugfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants