Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support authenticating with a bearer token #154

Merged
merged 1 commit into from
Oct 9, 2023
Merged

support authenticating with a bearer token #154

merged 1 commit into from
Oct 9, 2023

Conversation

pmenglund
Copy link
Member

No description provided.

@pmenglund pmenglund requested a review from a team October 9, 2023 16:38
@pmenglund pmenglund enabled auto-merge (squash) October 9, 2023 16:41
mpatou
mpatou approved these changes Oct 9, 2023
View reviewed changes
Copy link

@mpatou mpatou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but add the tests please. !

rockset_test.go Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Oct 9, 2023 •
edited

Pull Request Test Coverage Report for Build 812

  • 17 of 18 (94.44%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 58.678%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rockset.go 17 18 94.44%
Files with Coverage Reduction New Missed Lines %
rockset.go 1 75.68%
Totals Coverage Status
Change from base Build 806: 0.2%
Covered Lines: 1944
Relevant Lines: 3313
💛 - Coveralls

@pmenglund pmenglund merged commit 8b47326 into master Oct 9, 2023
3 checks passed
@pmenglund pmenglund deleted the pme/bearer-token branch October 9, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpatou mpatou mpatou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmenglund @coveralls @mpatou