Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve vi priv ergonomics #159

Merged
merged 1 commit into from
Oct 10, 2023
Merged

improve vi priv ergonomics #159

merged 1 commit into from
Oct 10, 2023

Conversation

pmenglund
Copy link
Member

No description provided.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 829

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 58.487%
Changes Missing Coverage Covered Lines Changed/Added Lines %
option/role.go 0 9 0.0%
Totals Coverage Status
Change from base Build 827: -0.07%
Covered Lines: 1940
Relevant Lines: 3317
💛 - Coveralls

@pmenglund pmenglund requested review from a-cong, a team and sofia099 and removed request for a-cong October 10, 2023 22:12
sofia099
sofia099 approved these changes Oct 10, 2023
View reviewed changes
Copy link

@sofia099 sofia099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@pmenglund pmenglund merged commit 70a1e3c into master Oct 10, 2023
3 of 4 checks passed
@pmenglund pmenglund deleted the pme/vi_privs branch October 10, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofia099 sofia099 sofia099 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmenglund @coveralls @sofia099