Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use git-lfs for cassettes #198

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Use git-lfs for cassettes #198

merged 4 commits into from
Jan 8, 2024

Conversation

sbaldwin-rs
Copy link
Contributor

@sbaldwin-rs sbaldwin-rs commented Jan 5, 2024 •
edited

Uses git-lfs for storing cassettes

@sbaldwin-rs sbaldwin-rs force-pushed the sbaldwin_dex_30 branch 3 times, most recently from e3e52ea to a5800fe Compare January 5, 2024 23:08
@coveralls
Copy link
Collaborator

coveralls commented Jan 5, 2024 •
edited

Pull Request Test Coverage Report for Build 1016

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.946%
Totals Coverage Status
Change from base Build 995: 0.0%
Covered Lines: 2233
Relevant Lines: 3492
💛 - Coveralls

@sbaldwin-rs sbaldwin-rs marked this pull request as ready for review January 5, 2024 23:19
pmenglund
pmenglund approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@pmenglund pmenglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

vcr_test.go Outdated Show resolved Hide resolved
@sbaldwin-rs sbaldwin-rs merged commit 5f3af4c into master Jan 8, 2024
4 checks passed
@sbaldwin-rs sbaldwin-rs deleted the sbaldwin_dex_30 branch January 8, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmenglund pmenglund pmenglund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbaldwin-rs @coveralls @pmenglund