Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ghost.json to resolve breaking changes in v1 #153

Merged
merged 1 commit into from Feb 2, 2019

Conversation

guppy0130
Copy link
Contributor

Upstream issue and resolution: docker-library/ghost#69
Previously opened issue (closed and reopened because of branching issues): #151
Installed and appears to be working on my installation.

Copy link
Contributor

@magicalyak magicalyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@magicalyak
Copy link
Contributor

@schakrava this is ready to merge

@phillxnet
Copy link
Member

@guppy0130 Thanks again for the fix and for your efforts in getting the git branch arrangement sorted.
Always safer to submit from specific branch as it can help with avoiding commiting more or less than was intended :)

@magicalyak Thanks yet again for another review. Most helpful.

And again, apologies to all for the significant delay in getting this merged.

@phillxnet phillxnet merged commit 9a81c8e into rockstor:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants