Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minecraft Bedrock Edition Server #226

Closed
wants to merge 20 commits into from
Closed

Minecraft Bedrock Edition Server #226

wants to merge 20 commits into from

Conversation

ROR89
Copy link

@ROR89 ROR89 commented Jun 8, 2020

To cover the universe of minecraft this time in its version for console and native windows 10.
great thanks to colleagues:
Hooverdan
Flox
phillxnet
who without them never been possible this small project

@phillxnet phillxnet added the needs review Test install, function, on / off behaviour, all links / info. label Jun 8, 2020
@phillxnet
Copy link
Member

@ROR89 Well done and thanks for getting this sorted. We just need a review, which is likely to suggests some minor changes, and we can hopefully then get this merged and published.

But one simple suggesting is that we like to give folks a link, within the description, to the docker image used. It's a bit scrappy how we do this currently but does present a better user interface. Take a look at the other more modern Rock-ons and you will see how it's done.

If you look at the following template (by @FroggyFlox ) for new Rock-on pull requests:

https://github.com/rockstor/rockon-registry/blob/master/.github/pull_request_template.md

you will see a checklist that would be good to include in your original post (by editing it's text). Once saved you can then tick them off as you get them sorted.

Hope that helps and again, thanks for taking the effort to get this far.

@magicalyak
Copy link
Contributor

The current pocketmine should be working, what's the difference between this and that one? They both are bedrock.

@phillxnet
Copy link
Member

As per @magicalyak outstanding question (2 years ago) I'll close this pr as now redundant. Do please re-open or better still re-submit ontop of our current master if there is interest.

@phillxnet phillxnet closed this Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Test install, function, on / off behaviour, all links / info. question
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants