Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Netdata (official) rock-on #266

Merged
merged 2 commits into from Dec 15, 2020

Conversation

FroggyFlox
Copy link
Member

@FroggyFlox FroggyFlox commented Dec 12, 2020

Fixes #236.

General information on project

This pull request proposes to add a new rock-on for the following project:

  • name: Netdata
  • website: https://www.netdata.cloud/
  • description: Netdata is a scalable, distributed, real-time, performance and health monitoring solution for Linux, FreeBSD and MacOS. Out of the box, it collects 1k to 5k metrics per server per second. It is the corresponding of running top, vmstat, iostat, iotop, sar, systemd-cgtop and a dozen more console tools in parallel. Netdata is very efficient in this: the daemon needs just 1% to 3% cpu of a single core.

Information on docker image

Checklist

  • Passes JSONlint validation
  • Entry added to root.json in alphabetical order (for new rock-on only)
  • "description" object lists and links to the docker image used
  • "description" object provides information on the image's particularities (advantage over another existing rock-on for the same project, for instance)
  • "website" object links to project's main website

@FroggyFlox
Copy link
Member Author

@Hooverdan96 ,

After a too much delay, I've finally made the changes we needed. I would appreciate if you could have a look at it on your side; it is the same rock-on as was previously in #237, but it cannot hurt to triple check the changes.

No worries if you don't have the time, and I'll merge it in. Thanks in advance!

@Hooverdan96
Copy link
Member

I'll look at it tomorrow if that works.

Copy link
Member

@Hooverdan96 Hooverdan96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FroggyFlox this looks good. I did another test install as well (for fun on my Tumbleweed Rockstor) and went all without a hitch. From my perspective: go for it!

@FroggyFlox
Copy link
Member Author

Thanks a lot, @Hooverdan96 !

I re-tested it myself and confirm it works as intended on both x86_64 and Aarch64 machines so I'm going to merge it now.

@phillxnet
Copy link
Member

@FroggyFlox Am I right in thinking that this Rock-on pr merge (Netdata (official)) was awaiting the review/merge/publication of:

"Add write-up for the Netdata_official rock-on ..." rockstor/rockstor-doc#266

If so then let me know if you want me to deal with publication. Otherwise I'm happy for your to proceed as usual with the publication step.

@FroggyFlox
Copy link
Member Author

@phillxnet, yes and no... I actually was waiting for a few other rock-ons that I wanted to merge before publishing but I seem to have dropped the ball on that one and got distracted by real-life obligations and then rockstor-core issues... I think we should get that published now as it has now been a while :-(

You can take care of it if that's not a problem on your end... let me know otherwise.

Sorry again for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netdata causing undesired AppArmor behavior
3 participants