Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Kanboard rockon #286

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Added a Kanboard rockon #286

merged 3 commits into from
Oct 11, 2021

Conversation

thedrjones
Copy link
Contributor

@thedrjones thedrjones commented May 12, 2021

General information on project

This pull request proposes to add a new rock-on for the following project:

  • name: Kanboard
  • website: https://kanboard.org/
  • description: Kanboard is a free and open source Kanban project management tool. The official docker repository is available for amd64, arm64 arm/v7 and arm/v6 architectures

Information on docker image

Checklist

  • Passes JSONlint validation
  • Entry added to root.json in alphabetical order (for new rock-on only)
  • "description" object lists and links to the docker image used
  • "description" object provides information on the image's particularities (advantage over another existing rock-on for the same project, for instance)
  • "website" object links to project's main website

@FroggyFlox FroggyFlox added the needs review Test install, function, on / off behaviour, all links / info. label May 13, 2021
Copy link
Member

@FroggyFlox FroggyFlox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thedrjones,

Thanks a lot for yet another contribution!
This is a nice addition to Rockstor so I'm eager to see it merged; I only have a few minor comments/requests that are all related to the capitalization of the Rock-on name.

kanboard.json Outdated Show resolved Hide resolved
kanboard.json Outdated Show resolved Hide resolved
@FroggyFlox
Copy link
Member

Hi @thedrjones,

First of all, please accept my apologies for taking so long in taking a look at your PR. I have now taken the time to properly test it in:

  • Rockstor-4.0.9 running on x86_64
  • Rockstor-4.0.9 running on Raspberry Pi4_Leap15.2
  • Rockstor-4.0.9 running on Raspberry Pi4_Leap15.3

It behaves as expected so my only requests are related to the capitalization of the Rock-on name.
Once these changes are in, I'll test a final time to make sure all is still right and then I'll merge.

Thanks again, and sorry for such a delay.

@FroggyFlox FroggyFlox added change requested A change has been requested and removed needs review Test install, function, on / off behaviour, all links / info. labels Oct 9, 2021
thedrjones and others added 2 commits October 9, 2021 22:27
Titlecase

Co-authored-by: FroggyFlox <30297881+FroggyFlox@users.noreply.github.com>
Titlecase

Co-authored-by: FroggyFlox <30297881+FroggyFlox@users.noreply.github.com>
@thedrjones
Copy link
Contributor Author

Changes placed for you. No worries about delays.

Copy link
Member

@FroggyFlox FroggyFlox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

@FroggyFlox
Copy link
Member

@thedrjones ,

Thanks for the little changes, I tested them again and confirmed it still works as intended. I'm thus merging it now.

Thanks again for another contribution! I'll try to do another merge and then work on publishing and announcing all of that.

Cheers!

@FroggyFlox FroggyFlox merged commit b3b98b0 into rockstor:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change requested A change has been requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants