-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a Kanboard rockon #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thedrjones,
Thanks a lot for yet another contribution!
This is a nice addition to Rockstor so I'm eager to see it merged; I only have a few minor comments/requests that are all related to the capitalization of the Rock-on name.
Hi @thedrjones, First of all, please accept my apologies for taking so long in taking a look at your PR. I have now taken the time to properly test it in:
It behaves as expected so my only requests are related to the capitalization of the Rock-on name. Thanks again, and sorry for such a delay. |
Titlecase Co-authored-by: FroggyFlox <30297881+FroggyFlox@users.noreply.github.com>
Titlecase Co-authored-by: FroggyFlox <30297881+FroggyFlox@users.noreply.github.com>
Changes placed for you. No worries about delays. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me.
Thanks for the little changes, I tested them again and confirmed it still works as intended. I'm thus merging it now. Thanks again for another contribution! I'll try to do another merge and then work on publishing and announcing all of that. Cheers! |
General information on project
This pull request proposes to add a new rock-on for the following project:
Information on docker image
Checklist
root.json
in alphabetical order (for new rock-on only)"description"
object lists and links to the docker image used"description"
object provides information on the image's particularities (advantage over another existing rock-on for the same project, for instance)"website"
object links to project's main website