-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New VPN Rockon Based on WireGuard #347
Conversation
Simple setup WireGuard container include WebUI
@Hooverdan96 Thanks for submitting this. It looks like a really nice Rock-on. |
@Hooverdan96 I've just tested this, as if merged, from a local repo and I get the following:
Looks like we could also do with a pr format checker in this repo re JSON :). Double checking in an online linter: http://jsonlint.vearne.cc/
Which looks to be pretty similar. Something it trying to tell us to get our GitHub actions in order re basic formatting checks :) . |
From a quick look at the raw file, it looks to be missing the description tag, likely lost in some merge of sorts! |
argh! As always, thanks for your due diligence. I definitely json linted it, but since that's always a copy/past action on my part, I must have screwed up something with the final commit. I'll take care of that. One the other hand, do we need this at all, since @FroggyFlox now introduced the wireguard setup as a native functionality (albeit still in testing channel? In any case, I'll fix the json ... |
Add mysteriously missing Rockon description tag.
I just wanted to chime in on the following:
I personally think we do as this Rock-On and Tailscale address two different possible uses or, most likely, two different types of users. Some may use Tailscale to remotely access their Rockstor box, while other may prefer to use their own, or an existing, WireGuard setup. |
ok, that makes sense to me too. I hopefully updated the json correctly this time around |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hooverdan96 Thanks for sumitting this, it looks to be a great addition. I've only tested install, on/off, uninstall - reinstall, persistence through reboot, and Web-UI button/loging. And have added a single client. But I understand you've proven actual function. So I'll go ahead and merge.
Quite the nice addition actually.
Installed
Web-UI
Tested on a custom 5.0.5-2764 Leap 15.5 base.
PR product PRODUCTION published. |
Simple setup WireGuard + Admin UI container
General information on project
This pull request proposes to add a new rock-on for the following project:
Information on docker image
Checklist
root.json
in alphabetical order (for new rock-on only)"description"
object lists and links to the docker image used"description"
object provides information on the image's particularities (advantage over another existing rock-on for the same project, for instance)"website"
object links to project's main website