Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace python-dbus with jeepney #2768

Open
phillxnet opened this issue Dec 16, 2023 · 1 comment
Open

Replace python-dbus with jeepney #2768

phillxnet opened this issue Dec 16, 2023 · 1 comment

Comments

@phillxnet
Copy link
Member

During #2744 we have: #2744 (comment)

@FroggyFlox & @Hooverdan96 I've just found the following upstream comment: https://gitlab.freedesktop.org/dbus/dbus-python/-/issues/48#note_2045548 from two months ago, as of this comment.

This project is only semi-maintained: merge requests welcome, but I am unlikely to be able to spend enough time on this to rewrite the tutorial.

As such we should look to limiting our use of this library, & ideally removing it in time.

I think users.py is currenlty the only user:

lbuildvm:/opt/rockstor/src # grep -R "import dbus"
rockstor/system/users.py:import dbus

From @FroggyFlox comment #2728 (comment)

Interesting that it pulls jeepney as a dependency. This actually is my current top candidate to replace python-dbus (#2744 (comment)).

So it looks like our existing secondary dependency on jeepney, from our direct dependency on keyring-pass, is a nice convenient replacement for python-dbus.

PyPi: https://pypi.org/project/jeepney/
0.8.0 Released: Apr 3, 2022
Requires: Python >=3.7

@FroggyFlox
Copy link
Member

Thanks a lot for creating this issue. I thought I would share a few links from where my current interest in jeepney comes from:
https://gitlab.freedesktop.org/dbus/dbus-python/-/commit/f74338c72b79af840d4755a821e421688a9743fb
https://stackoverflow.com/a/76576713

The fact that keyring is using jeepney is reassuring and supports its use for our own needs. We'll have to establish some common functions to easily interact with it, but it seems to offer quite a few options: https://jeepney.readthedocs.io/en/latest/integrate.html

Of note, this issue should probably affect #2680 as we would thus rely on our jeepney use instead of pystemd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants