Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Leap 15.3 profiles for x86_64 & Aarch64 (#46) #48

Conversation

phillxnet
Copy link
Member

Initial proposal for Leap 15.3 profile additions for both architectures with a specific Pi4 variant.

Fixes #46
@FroggyFlox Ready for review.
This is not intended to be the end result, but just to get us started. We can then tweak/fix in further more focused pull requests and hopefully attract more committers to refine these profiles as openSUSE Leap 15.3 moves through it's beta test phase.

Includes:

  • Leap 15.3 profile entries for x86_64, RaspberryPi4, ARM64EFI.
  • Addition of these profiles to the existing 'preferences' sections.
  • Addition of the Leap 15.3 specific repo entries.
  • Switch, in Leap 15.3 + profiles, to home_rockstor for shellinabox; rather than the broader OBS shells repo, or the more Ten64 drivers focused mcbridematt repo.
  • Normalise on https for all OBS repos.
  • Addition of OBS page link for kiwi repos.

Readme commit - new section for in-dev profiles.

Includes:
- Leap 15.3 profile entries for x86_64, RaspberryPi4, ARM64EFI.
- Addition of these profiles to the existing 'preferences' sections.
- Addition of the Leap 15.3 specific repo entries.
- Switch, in Leap 15.3 + profiles, to home_rockstor for shellinabox;
rather than the broader OBS shells repo, or the more Ten64 drivers
focused mcbridematt repo.
- Normalise on https for all OBS repos.
- Addition of OBS page link for kiwi repos.
…ockstor#46)

We will, periodically, have in-development profiles. This is the case
as we develop the 'Built on openSUSE' Leap 15.3 (beta) variants. This
new section header can serve to fulfill the surfacing of this work.
@FroggyFlox
Copy link
Member

@phillxnet ,

As I've been having issues with building in RPi4, I was curious about the following section (L460):

    <packages type="image" profiles="Leap15.2.RaspberryPi4">
        <package name="raspberrypi-firmware" arch="aarch64"/>
        <package name="raspberrypi-firmware-config" arch="aarch64"/>
        <package name="raspberrypi-firmware-dt" arch="aarch64"/>
        <!-- For WiFi: -->
        <package name="bcm43xx-firmware"/>
        <package
                name="kernel-firmware"/><!-- Fix choice between kernel-firmware and kernel-firmware-all -->
        <package name="u-boot-rpiarm64" arch="aarch64"/>
    </packages>

Shouldn't we add the Leap15.3.RaspberryPi4 profile there as well so that we install those packages as well in Leap15.3?

Also, it's out of the scope of this PR, but it seems the RPi4 kiwi-templates has been updated a lot in the recent months; maybe we should update according to:

@phillxnet
Copy link
Member Author

@FroggyFlox Thanks for the prompts here:
Re:

Shouldn't we add the Leap15.3.RaspberryPi4 profile there as well so that we install those packages as well in Leap15.3?

Exactly. I'll get on that now. Don't know what distracted me this time but thanks.

@phillxnet
Copy link
Member Author

@FroggyFlox Re

Also, it's out of the scope of this PR, but it seems the RPi4 kiwi-templates has been updated a lot in the recent months; maybe we should update according to:

Thanks. lets see if our existing changes still work and then open a new pr for these updates, as I agree they should probably have their own Pi4 specific pull request to address the 'special' treatment these images need.

@phillxnet
Copy link
Member Author

@FroggyFlox Would you mind opening a new issue re the Pi4 'treatment' with regard to moving us closer to the newer way of doing things re Pi4. When we initially did this kiwi-ng config I did use, as a guide, the latest upstream configs (sited at the beginning of the config in comments) but of course that was a while ago now.

Cheers. That way we can jump on that one if it needs to be done to get working Pi4 images, post me fixing up the things I simply forgot in this pr.

Special treatment is required for the Pi4 targets, these include Pi
specific packages and config. These were missed in earlier Leap 15.3
commits in both package image type and in the relevant section of
config.sh.
@phillxnet
Copy link
Member Author

@FroggyFlox I've now pushed another commit to this pr that addresses the missing profile entry you spotted and the config.sh reference we spoke about in side-channel discussions. If you could take another quick look that would be grand.
Cheers.

@phillxnet
Copy link
Member Author

@FroggyFlox Thanks for the review and finding the earlier omissions here.

I'll merge what we have here for now so we can move to the more specific issues such as aligning more with upstream JeOS, as you mentioned above, and the rsyslog / systemd-journal issue you mentioned in our side channel chat.

@phillxnet phillxnet merged commit 0bd57b7 into rockstor:master Apr 28, 2021
@phillxnet phillxnet deleted the 46_Add_Leap_15.3_profile_for_x86_64_&_Aarch64 branch April 28, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Leap 15.3 profile for x86_64 & Aarch64
2 participants