Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.6 Release Issues] Test Suite: install_mirrorlist_graphical on rocky-8.6-universal #91

Merged
merged 1 commit into from
May 14, 2022

Conversation

akatch
Copy link
Contributor

@akatch akatch commented May 14, 2022

Description

This PR adds a needle with the new Security Policy spoke icon. Fixes #89 when merged.

How Has This Been Tested?

openqa-cli api -X POST isos ISO=Rocky-8.6-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.6 BUILD=8.6_universal_$(date +%Y%m%d.%H%M%S).0 TEST=install_mirrorlist_graphical

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@akatch akatch changed the base branch from develop to 8.6_release_fixes May 14, 2022 15:28
Copy link
Member

@tcooper tcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for the detail in the issue which clearly spelled out what was wrong and what this change should do. We will want to be aware of the possible need to update / add as the Security spoke can now be transited. We don't have test(s) yet for SCAP / CIS stuff and that was manually tested by @atomicturtle but we should add that to openQA so it can be done automatically. This has been discussed in MM a bit while it was being developed.

@akatch
Copy link
Contributor Author

akatch commented May 14, 2022

This looks good. Thanks for the detail in the issue which clearly spelled out what was wrong and what this change should do. We will want to be aware of the possible need to update / add as the Security spoke can now be transited. We don't have test(s) yet for SCAP / CIS stuff and that was manually tested by @atomicturtle but we should add that to openQA so it can be done automatically. This has been discussed in MM a bit while it was being developed.

Thanks Trevor. As outlined in the timeline for this PR, I have created a stub feature request for those tests here. We should definitely make that issue description more robust, but at least now we can't forget about it.

@akatch akatch merged commit 2c2ce21 into rocky-linux:8.6_release_fixes May 14, 2022
@akatch akatch deleted the akatch_issue_89 branch May 14, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [8.6 Release Issues] Security Policy spoke icon changed
2 participants