Skip to content
This repository has been archived by the owner on Feb 7, 2021. It is now read-only.

Updated Slack join link #7

Merged
merged 6 commits into from
Dec 11, 2020
Merged

Updated Slack join link #7

merged 6 commits into from
Dec 11, 2020

Conversation

zeeshanjamal16
Copy link
Contributor

@zeeshanjamal16 zeeshanjamal16 commented Dec 11, 2020

The old slack join link was expired. Replaced it with the new slack join link.

Fixes #6

@vercel
Copy link

vercel bot commented Dec 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rocky-linux/rockylinux/ksavb1gwl
✅ Preview: https://rockylinux-git-main.rocky-linux.vercel.app

@Addvilz
Copy link
Contributor

Addvilz commented Dec 11, 2020

@zeeshanjamal16 please, comment on the relevant task OR create one BEFORE doing something.

You are missing the link in several files - footer, 404, etc. Please grep the whole source base for slack.com and replace the link everywhere.

@zeeshanjamal16
Copy link
Contributor Author

@Addvilz
Sure. I wiil keep in mind.
I have updated the link in other files as well.

public/index.html Outdated Show resolved Hide resolved
@hbjydev
Copy link
Contributor

hbjydev commented Dec 11, 2020

Would you be able to store the invite link as a variable in the config.toml to ensure that we never have to go searching for every instance of slack.com again?

An example of how to reference config.toml values can be found in the layouts/partials/meta/site-twittercard.html file.

@Addvilz Addvilz self-requested a review December 11, 2020 15:24
@zeeshanjamal16
Copy link
Contributor Author

@hbjydev
Updated hard coded links to config.toml. Can you please check the same?

@danieltharp danieltharp merged commit bed1a88 into rocky-linux:main Dec 11, 2020
@elysweyr elysweyr mentioned this pull request Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack invite link invalid and hardcoded
4 participants