Incorrect track bug smallest absolute value match #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://savannah.gnu.org/bugs/index.php?49831 This is the shortest absolute match patch.
The patch wasn't fully correctly applied. A return statement was left behind in the code that shouldn't have been there.
…st-absolute-value-match Fix failing test
…anomalies need to be reported
…st-absolute-value-match Use LONG_MAX as sentinel value and use min_offset to check if errors/anomalies need to be reported
|
@enzo1982 would you do the final review here? |
|
Yes, I'll have a look at it! |
|
All looks good now; I merged the pull request. One more thing, though: I would suggest that we keep the cdda2.bin test file in git. We can exclude it from release tarballs by not adding it to Makefile.am. That way tarballs stay small and we still has easy access to the test file - everybody wins. |
Makes sense. Feel free to add it from https://mega.nz/#!alBBhS7Q!C3O48z4GcNtcqEpVZe01S6MjyGt-0kGfHyjpdecosFU I think we've tested that it already is excluded from the tarball. |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.