Ensure consistent results if autogen.sh is run more than once #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, make dist after a second autogen.sh will generate a Makefile.in that differs from after the first autogen.sh: diff t5/remake-4.3-1+dbg-1.6/Makefile.in t6/remake-4.3-1+dbg-1.6/Makefile.in 334c334,335 < build-aux/install-sh build-aux/missing --- > build-aux/install-sh build-aux/mdate-sh build-aux/missing \ > build-aux/texinfo.tex But that is the only difference(!). Make install results from either tarball are identical. However the small change above does result in make dist-xz adding 440 bytes to the tarball.
|
Hi Rocky, When I first noticed this discrepancy, I thought it would have serious consequences. Spent some time checking for them but found there weren't any. This patch might save someone else's time doing the same. |
rocky
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, make dist after a second autogen.sh will generate a Makefile.in that differs from after the first autogen.sh:
diff t5/remake-4.3-1+dbg-1.6/Makefile.in t6/remake-4.3-1+dbg-1.6/Makefile.in 334c334,335
< build-aux/install-sh build-aux/missing
But that is the only difference(!).
Make install results from either tarball are identical.
However the small change above does result in make dist-xz adding 440 bytes to the tarball.