Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIPIFY] An argument of a function used as macro argument is not hipified #9

Closed
emankov opened this issue Sep 1, 2016 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@emankov
Copy link
Collaborator

emankov commented Sep 1, 2016

Example (Shoc's NeuralNet.cu):

CUDA_SAFE_CALL(cudaMemcpy(&D__TRAINING_DATA_X_2D[i_IMAGE_SIZE], TRAINING_DATA_X[i], sizeof(float)_IMAGE_SIZE, cudaMemcpyHostToDevice));

where:

define CUDA_SAFE_CALL(call) /.../

After hipifying now:
CUDA_SAFE_CALL(hipMemcpy(&D__TEST_DATA_X_2D[i_IMAGE_SIZE], TEST_DATA_X[i], sizeof(float)_IMAGE_SIZE, cudaMemcpyHostToDevice));

Should be:
CUDA_SAFE_CALL(hipMemcpy(&D__TEST_DATA_X_2D[i_IMAGE_SIZE], TEST_DATA_X[i], sizeof(float)_IMAGE_SIZE, hipMemcpyHostToDevice));

@emankov emankov self-assigned this Sep 1, 2016
@emankov
Copy link
Collaborator Author

emankov commented Dec 27, 2016

Fixed.
/gerritgit/compute/ec/hip (amd-develop branch):
SHA-1: 5ec0488c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant