Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have CI build docs in lieu of current update-docs.sh script #22

Closed
koomie opened this issue Nov 10, 2022 · 4 comments
Closed

Have CI build docs in lieu of current update-docs.sh script #22

koomie opened this issue Nov 10, 2022 · 4 comments
Labels
CI Continuous Integration documentation Improvements or additions to documentation
Milestone

Comments

@koomie
Copy link
Collaborator

koomie commented Nov 10, 2022

Would be nice to clean up the docs build a bit and have a companion github action land html from markdown. Also, I'd be in favor of cleaning up the branches so that all docs collateral only resides in the gh-pages branch. In that case we would remove from main and dev.

@koomie koomie added documentation Improvements or additions to documentation CI Continuous Integration labels Nov 10, 2022
@koomie koomie added this to the v1.0.5 milestone Nov 10, 2022
@jrmadsen
Copy link

I prefer the markdown source to be part of the repo. It allows you to update/modify the docs alongside changes in the source (same PR) and can also help while searching for things in repo

@jrmadsen
Copy link

But I agree, there should be a GitHub action that updates the docs when a release occurs. I haven't gotten around to it in omnitrace but if y'all figure it out, lmk so I can steal it.

@skyreflectedinmirrors
Copy link
Contributor

Also, turn warnings as errors on (if possible) for things like #33

@koomie koomie removed this from the v1.0.5 milestone Dec 12, 2022
@coleramos425 coleramos425 added this to the v1.0.6 milestone Dec 12, 2022
koomie added a commit that referenced this issue Dec 20, 2022
…on using

sphinx and a rtd theme. This action is triggered via documentation-related
changes landed on the "main" branch (#22).

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
koomie added a commit that referenced this issue Dec 21, 2022
…on using

sphinx and a rtd theme. This action is triggered via documentation-related
changes landed on the "main" branch (#22).

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
koomie added a commit that referenced this issue Dec 21, 2022
…umentation

builds (#22)

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
@koomie
Copy link
Collaborator Author

koomie commented Dec 21, 2022

This is now live with the introduction of a new github action: docs.yml

In the current configuration, the authoritative markdown inputs live in src/docs on the main branch. When documentation-related changes occur on the main branch, a CI job will build the latest docs using a sphinx container. These are then deployed to GitHub pages using the deploy-pages action.

Note that with this approach, static html files no longer need to reside in the repository.

@koomie koomie closed this as completed Dec 21, 2022
feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 6, 2023
…on using

sphinx and a rtd theme. This action is triggered via documentation-related
changes landed on the "main" branch (ROCm#22).

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
Signed-off-by: fei.zheng <fei.zheng@amd.com>
feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 6, 2023
…on using

sphinx and a rtd theme. This action is triggered via documentation-related
changes landed on the "main" branch (ROCm#22).

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
Signed-off-by: fei.zheng <fei.zheng@amd.com>
feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 6, 2023
…umentation

builds (ROCm#22)

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
Signed-off-by: fei.zheng <fei.zheng@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants