Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "Get" method for es client #81

Merged
merged 1 commit into from
May 14, 2021
Merged

add "Get" method for es client #81

merged 1 commit into from
May 14, 2021

Conversation

mrparkers
Copy link
Contributor

needed for rode's ListGenericResourceVersions rpc

@codecov-commenter
Copy link

Codecov Report

Merging #81 (cdb8dfd) into main (5c2d664) will decrease coverage by 0.15%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   85.90%   85.74%   -0.16%     
==========================================
  Files          11       11              
  Lines        1220     1235      +15     
==========================================
+ Hits         1048     1059      +11     
- Misses        108      110       +2     
- Partials       64       66       +2     
Impacted Files Coverage Δ
go/v1beta1/storage/esutil/client.go 81.81% <73.33%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2d664...cdb8dfd. Read the comment docs.

@mrparkers mrparkers merged commit ceebf75 into main May 14, 2021
@mrparkers mrparkers deleted the client-get branch May 14, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants