Implement bounding box calculation on iOS #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rodgomesc any update about merging this? |
Repository owner
deleted a comment from
rodgomescrn
Jan 11, 2022
|
hey, sorry for the delayed feedback, i’ll try to test this that week and release a new version |
|
Nice to see this PR! I've tested it with the front camera of a 1st-gen iPhone SE and worked flawlessly. Seems to be working exactly as in Android, with the exception of x coordinates, that are not mirrored as found in #10. IMO this is the correct behaviour. |
Closed
|
Please update latest version on npm! |
bglgwyng
pushed a commit
to bglgwyng/vision-camera-face-detector
that referenced
this pull request
Aug 20, 2022
Implement bounding box calculation on iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boundsattribute on Face always returns empty object on iOS, this PR fixes it. Fix #3