Feature/exportToXML #62
Conversation
|
|
||
| @NoArgsConstructor | ||
| @XmlRootElement(name = "instructions") | ||
| abstract class JFixturesResultImpl implements JFixturesResult { |
There was a problem hiding this comment.
Let's rename it to JFixturesResultBase since it is not an implementation but an abstract class?
| abstract class JFixturesResultImpl implements JFixturesResult { | ||
| private String fixturesFolder; | ||
|
|
||
| @Setter |
There was a problem hiding this comment.
Why do we need @Setter? Can't we put XML related annotation on getter(getInstructions() method) ?
There was a problem hiding this comment.
If getter is an allowed mechanism, then, perhaos, we can remove this field at all or leave only getInstructions()?
| @@ -24,6 +26,11 @@ public FixtureValue(Object value) { | |||
| } | |||
| } | |||
|
|
|||
| @XmlValue | |||
There was a problem hiding this comment.
Any reason not to serialize the type field?
There was a problem hiding this comment.
Do you mean
@XmlValue private final Object value;
| @@ -24,6 +26,11 @@ public FixtureValue(Object value) { | |||
| } | |||
| } | |||
|
|
|||
| @XmlValue | |||
| public String getStringValue() { | |||
There was a problem hiding this comment.
Can it serialize if the method is defined like Object getValue()?
There was a problem hiding this comment.
`fixturesResult.asString() == EXPECTED_XML
| |
| java.lang.NullPointerException
com.github.vkorobkov.jfixtures.fluent.impl.XmlJFixturesResultImpl@548a24a
at com.github.vkorobkov.jfixtures.fluent.impl.XmlJFixturesResultImplTest.processes fixtures to string(XmlJFixturesResultImplTest.groovy:57)`
|
|
||
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| @XmlRootElement(name = "instructions") |
There was a problem hiding this comment.
Can @XmlRootElement be moved into XmlJFixturesResultImpl?
|
|
||
| @SneakyThrows | ||
| private Marshaller getMarshaller() { | ||
| val jaxbContext = JAXBContext.newInstance(JFixturesResultBase.class); |
There was a problem hiding this comment.
Can it be instantiated like JAXBContext.newInstance(getClass())?
| @@ -29,6 +31,11 @@ public String toString() { | |||
| return String.valueOf(value); | |||
| } | |||
|
|
|||
| @XmlValue | |||
| String getValueAsString() { | |||
There was a problem hiding this comment.
Rename to getXmlRepresentation?
| @@ -4,6 +4,8 @@ | |||
| import lombok.EqualsAndHashCode; | |||
| import lombok.Getter; | |||
|
|
|||
| import javax.xml.bind.annotation.XmlValue; | |||
There was a problem hiding this comment.
Why we don't add type field into result XML?
There was a problem hiding this comment.
So it could be <value type="SQL">DEFAULT</value>
| @@ -4,6 +4,8 @@ | |||
| import lombok.EqualsAndHashCode; | |||
| import lombok.Getter; | |||
|
|
|||
| import javax.xml.bind.annotation.XmlValue; | |||
| @@ -4,6 +4,8 @@ | |||
| import lombok.EqualsAndHashCode; | |||
| import lombok.Getter; | |||
|
|
|||
| import javax.xml.bind.annotation.XmlValue; | |||
There was a problem hiding this comment.
So it could be <value type="SQL">DEFAULT</value>
| abstract class JFixturesResultBase implements JFixturesResult { | ||
| private String fixturesFolder; | ||
|
|
||
| @XmlElements({ |
There was a problem hiding this comment.
Can we move this XML specific annotation to XmlJFixturesResultImpl since the base class should not know about the implementation and technical details of its children?
@Override
@XmlElements( .... )
List<Instruction> getInstructions() {
return super.getInstructions();
}
No description provided.