Print nice error when module not found in forge

Closes #5
rodjek · Jun 20, 2012 · cf0ce30 · cf0ce30
1 parent 5666e90
commit cf0ce30
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/lib/librarian/puppet/source/forge.rb b/lib/librarian/puppet/source/forge.rb
@@ -21,6 +21,10 @@ def initialize(source, name)
 
           def versions
             data = api_call("#{name}.json")
+            if data.nil?
+              raise Error, "Unable to find module '#{name}' on #{source}"
+            end
+
             data['releases'].map { |r| r['version'] }.sort.reverse
           end
 
@@ -79,9 +83,12 @@ def cache_version_unpacked!(version)
           def api_call(path)
             base_url = source.to_s
             resp = Net::HTTP.get_response(URI.parse("#{base_url}/#{path}"))
-            data = resp.body
+            if resp.code.to_i != 200
-
+              nil
-            JSON.parse(data)
+            else
+              data = resp.body
+              JSON.parse(data)
+            end
           end
         end