Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version range is not parsed correctly #82

Closed
igalic opened this issue Mar 12, 2013 · 3 comments
Closed

Version range is not parsed correctly #82

igalic opened this issue Mar 12, 2013 · 3 comments

Comments

@igalic
Copy link

igalic commented Mar 12, 2013

In our Puppetfile we currently have (among others)

mod "postgresql",
  :git => "git://github.com/puppetlabs/puppet-postgresql.git"

When running librarian-puppet install we get:

/opt/bw/lib/ruby/1.9.1/rubygems/requirement.rb:81:in `parse': Illformed requirement [">=3.2.0 <4.0.0"] (ArgumentError)
    from /opt/bw/lib/ruby/1.9.1/rubygems/requirement.rb:106:in `block in initialize'
    from /opt/bw/lib/ruby/1.9.1/rubygems/requirement.rb:106:in `map!'
    from /opt/bw/lib/ruby/1.9.1/rubygems/requirement.rb:106:in `initialize'
    from /opt/bw/lib/ruby/1.9.1/rubygems/requirement.rb:47:in `new'
    from /opt/bw/lib/ruby/1.9.1/rubygems/requirement.rb:47:in `create'
    from /opt/bw/lib/ruby/gems/1.9.1/gems/librarian-puppet-0.9.8/vendor/librarian/lib/librarian/dependency.rb:10:in `initialize'
    from /opt/bw/lib/ruby/gems/1.9.1/gems/librarian-puppet-0.9.8/vendor/librarian/lib/librarian/dependency.rb:50:in `new'
    from /opt/bw/lib/ruby/gems/1.9.1/gems/librarian-puppet-0.9.8/vendor/librarian/lib/librarian/dependency.rb:50:in `initialize'
    from /opt/bw/lib/ruby/gems/1.9.1/gems/librarian-puppet-0.9.8/lib/librarian/puppet/source/git.rb:103:in `new'
    from /opt/bw/lib/ruby/gems/1.9.1/gems/librarian-puppet-0.9.8/lib/librarian/puppet/source/git.rb:103:in `block in fetch_dependencies'
    from /opt/bw/lib/ruby/gems/1.9.1/gems/librarian-puppet-0.9.8/lib/librarian/puppet/source/git.rb:102:in `each'
    from /opt/bw/lib/ruby/gems/1.9.1/gems/librarian-puppet-0.9.8/lib/librarian/puppet/source/git.rb:102:in `map'
    from /opt/bw/lib/ruby/gems/1.9.1/gems/librarian-puppet-0.9.8/lib/librarian/puppet/source/git.rb:102:in `fetch_dependencies'
    from /opt/bw/lib/ruby/gems/1.9.1/gems/librarian-puppet-0.9.8/vendor/librarian/lib/librarian/manifest.rb:113:in `fetch_dependencies!'
    from /opt/bw/lib/ruby/gems/1.9.1/gems/librarian-puppet-0.9.8/vendor/librarian/lib/librarian/manifest.rb:105:in `fetched_dependencies'
    from /opt/bw/lib/ruby/gems/1.9.1/gems/librarian-puppet-0.9.8/vendor/librarian/lib/librarian/manifest.rb:69:in `dependencies'
    from /opt/bw/lib/ruby/gems/1.9.1/gems/librarian-puppet-0.9.8/vendor/librarian/lib/librarian/resolver/implementation.rb:67:in `block (4 levels) in recursive_resolve'
    from /opt/bw/lib/ruby/gems/1.9.1/gems/librarian-puppet-0.9.8/vendor/librarian/lib/librarian/resolver/implementation.rb:103:in `scope'
....

puppetlabs-postgres/Modulefile contains a range: dependency 'puppetlabs/stdlib', '>=3.2.0 <4.0.0', which seems to make librarian stumble.

This however, is correct syntax, according to http://docs.puppetlabs.com/puppet/3/reference/modules_publishing.html#dependencies-in-the-modulefile

@gotcha
Copy link

gotcha commented Mar 19, 2013

I looked into puppet. They use their own semver to work with version requirements.

@igalic
Copy link
Author

igalic commented Mar 20, 2013

Yes, but it's apache licensed, so it can be borrowed!

@rodjek
Copy link
Owner

rodjek commented Apr 18, 2013

Fixed in #87

@rodjek rodjek closed this as completed Apr 18, 2013
ekohl pushed a commit to ekohl/librarian-puppet that referenced this issue Jun 2, 2021
Drop Puppet 3/Puppet 4 and Ruby 2.0/2.1/2.2 testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants