Prevent error when using any module with a release candidate #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some modules on the forge have versions like 0.5.0-rc1. It turns out that the - causes havoc in Librarian, resulting in an exception that blocks the use of librarian-puppet. I saw this first with the puppetlabs/apache module. Basically if you include it or anything that depends on it librarian-puppet won't work. This patch resolves this in a hacky, but apparently working, way. It replaces - with a period internally, and then swaps it again to a - when making a call to the forge.
|
Seems to address the same issue as #64 (in that case, the versions were ignored instead) |
|
Unfortunately this patch only works with -rc versions, and correct versions in the forge with .rc (ie. 1.0.rc1) would fail |
|
This should have been fixed already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some modules on the forge have versions like 0.5.0-rc1. It turns out
that the - causes havoc in Librarian, resulting in an exception that
blocks the use of librarian-puppet. I saw this first with the
puppetlabs/apache module. Basically if you include it or anything that
depends on it librarian-puppet won't work.
This patch resolves this in a hacky, but apparently working, way. It
replaces - with a period internally, and then swaps it again to a - when
making a call to the forge.