Merge pull request #500 from Lucas-C/master

Bugfix: properly handling $gronk-$grouik with --fix (fix #442)

README.md

@@ -174,6 +174,11 @@ If you find a bug in puppet-lint or its results, please create an issue in the
 [repo issues tracker](https://github.com/rodjek/puppet-lint/issues/).  Bonus
 points will be awarded if you also include a patch that fixes the issue.
 
+## Executing puppet-lint tests suite
+
+    bundle exec rspec [spec/puppet-lint/a_single_test.rb]
+
+
 ## Thank You
 
 Many thanks to the following people for contributing to puppet-lint

lib/puppet-lint/lexer.rb

@@ -170,7 +170,7 @@ def tokenise(code)
         end
 
         unless found
-          if var_name = chunk[/\A\$((::)?([\w-]+::)*[\w-]+(\[.+?\])*)/, 1]
+          if var_name = chunk[/\A\$((::)?([\w]+::)*[\w]+(\[.+?\])*)/, 1]
             length = var_name.size + 1
             tokens << new_token(:VARIABLE, var_name, length)
 
@@ -346,7 +346,7 @@ def interpolate_string(string, line, column)
             tokens << new_token(:DQMID, value, value.size, :line => line, :column => token_column)
           end
           if ss.scan(/\{/).nil?
-            var_name = ss.scan(/(::)?([\w-]+::)*[\w-]+/)
+            var_name = ss.scan(/(::)?([\w]+::)*[\w]+/)
             if var_name.nil?
               token_column = column + ss.pos - 1
               tokens << new_token(:DQMID, "$", 1, :line => line, :column => token_column)

lib/puppet-lint/plugins/check_variables.rb

@@ -7,7 +7,7 @@ def check
     tokens.select { |r|
       VARIABLE_DASH_TYPES.include? r.type
     }.each do |token|
-      if token.value.gsub(/\[.+?\]/, '').match(/-/)
+      if not token.next_token.nil? and Set[:DQMID, :DQPOST, :MINUS].include? token.next_token.type and token.next_token.value.start_with? '-'
         notify :warning, {
           :message => 'variable contains a dash',
           :line    => token.line,

spec/puppet-lint/plugins/check_strings/variables_not_enclosed_spec.rb

@@ -39,18 +39,18 @@
     end
 
     context 'variable not enclosed in {}' do
-      let(:code) { '" $gronk"' }
+      let(:code) { '" $gronk-$grouik"' }
 
       it 'should only detect a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems).to have(2).problem
       end
 
       it 'should fix the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(3)
       end
 
       it 'should enclose the variable in braces' do
-        expect(manifest).to eq('" ${gronk}"')
+        expect(manifest).to eq('" ${gronk}-${grouik}"')
       end
     end