Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PuppetLint.configuration.ignore_paths not working 1.1.0 #355

Closed
edestecd opened this issue Oct 29, 2014 · 11 comments
Closed

PuppetLint.configuration.ignore_paths not working 1.1.0 #355

edestecd opened this issue Oct 29, 2014 · 11 comments
Labels

Comments

@edestecd
Copy link

If you define:

PuppetLint.configuration.ignore_paths in Rakefile
it will not work and the ignore paths will be linted.

Environment:

  • ruby '2.1.2', :engine => 'ruby', :engine_version => '2.1.2', :patchlevel => '95'
  • puppet-lint (1.1.0)
  • rake (10.3.2)
@jhoblitt
Copy link

I've hit this too -- it's pretty shocking/scary to see the output when it starts running through fixture modules!

@Aethylred
Copy link

There's a workaround:

#331

@tuxinaut
Copy link

Any progress?

@edestecd
Copy link
Author

I'm not sure if this is fixed. I have it locked to 1.0.1 in my Gemfiles.
I guess I need to test on newer versions. Are you still having this issue?

@tuxinaut
Copy link

Yes I have still this issue with version 1.1.0

gerhardsam added a commit to gerhardsam/puppet-jenkins_job_builder that referenced this issue Apr 27, 2015
This is a workaround for a bug in puppet-lint 1.1.0.

See rodjek/puppet-lint#355
jantman added a commit to jantman/puppet-archlinux-macbookretina that referenced this issue Sep 19, 2015
jantman added a commit to jantman/puppet-archlinux-workstation that referenced this issue Sep 19, 2015
jantman added a commit to jantman/modulesync_configs that referenced this issue Sep 19, 2015
@brettswift
Copy link

over a year later.. Is this bug forgotten? Still broken on 1.1.0.

@rnelson0
Copy link
Collaborator

It's been a while and between this and #331, I think the problem is that you expect to use:

PuppetLint.configuration.ignore_paths = ["spec/**/*.pp", "vendor/**/*.pp", "modules/**/*.pp"]

But instead you must use (from #331):

Rake::Task[:lint].clear
PuppetLint::RakeTask.new :lint do |config|
  config.ignore_paths   = ["spec/**/*.pp", "vendor/**/*.pp", "modules/**/*.pp"]
end

Is that a correct summary?

openstack-gerrit pushed a commit to openstack-archive/fuel-plugin-influxdb-grafana that referenced this issue Jun 23, 2016
See rodjek/puppet-lint#355

Change-Id: Id35fee33d0a0ded5d5a0dd7b1b4f161c6e4b65c6
openstack-gerrit pushed a commit to openstack-archive/fuel-plugin-lma-collector that referenced this issue Jun 23, 2016
See rodjek/puppet-lint#355

Change-Id: I57cab1e46e2cf27827fff21f1e980382474defb4
openstack-gerrit pushed a commit to openstack-archive/fuel-plugin-lma-infrastructure-alerting that referenced this issue Jun 23, 2016
See rodjek/puppet-lint#355

Change-Id: I67e28363b0e23912a6e813e5136bc770081bdb94
openstack-gerrit pushed a commit to openstack-archive/fuel-plugin-elasticsearch-kibana that referenced this issue Jun 24, 2016
See rodjek/puppet-lint#355

Change-Id: I74bec9d1a1fb9bb84acf5c494c9f7f003040c617
@rnelson0
Copy link
Collaborator

@edestecd @brettswift Can you review and see if this is still an issue with 2.0.x or HEAD? Thanks!

@es1o
Copy link

es1o commented Dec 7, 2016

@rnelson0
Hi, I use puppet-lint 2.0.2 and for me works this configuration in Rakefile:

require 'puppet-lint/tasks/puppet-lint'

PuppetLint::RakeTask.new :lint do |config|
    config.ignore_paths = ["modules/stdlib/**/*.pp"]
end

@brettswift
Copy link

@rnelson0 6 months later.. tested and works!

@rnelson0
Copy link
Collaborator

Thanks for verification all. Closing this out.

jantman added a commit to jantman/modulesync_configs that referenced this issue Dec 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants