New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --relative command line argument for autoload structure testing #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This argument will cause the autoload layout class plugin to ignore the top-most directory in the structure. This is useful for the common case where the folder name is not the same as the module name in raw source code. Example: puppet-foo/manifests/init.pp has 'class foo { }' puppet-lint puppet-foo returns errors puppet-lint --relative puppet-foo returns no errors This allows us to continue testing the general autoload layout if we purposely compare relatively.
…tive to the module root - not the working directory.
rodjek
pushed a commit
that referenced
this pull request
Mar 4, 2014
Add --relative command line argument for autoload structure testing
gloppasglop
added a commit
to gloppasglop/puppet-memcached
that referenced
this pull request
Aug 21, 2014
- This is to avoid issue cause by the fact that - foloder name is differemnt from module name - see rodjek/puppet-lint#252
xbezdick
added a commit
to xbezdick/openstack-puppet-modules
that referenced
this pull request
Dec 2, 2014
5869cad Merge pull request redhat-openstack#51 from jburnham/feature/pidfile-support 57fdf41 Merge pull request redhat-openstack#50 from joshuaspence/master 7066392 Add support for custom and disabling of pidfiles. 5973ec8 Add support for large memory pages b1c0011 new release v2.6.0 7b8ce2a Merge branch 'gloppasglop-feature_sasl' b1bcddd Merge branch 'feature_sasl' of https://github.com/gloppasglop/puppet-memcached into gloppasglop-feature_sasl 8c340fd Merge pull request redhat-openstack#49 from misterdorm/puppet37x 66fd812 Merge pull request redhat-openstack#46 from sxd/master e0c717f Replaced references to type() function with is_string() for Puppet 3.7.x, which now reserves the "type" keyword for future use. e368e33 Add relative option to puppet-lint - This is to avoid issue cause by the fact that - foloder name is differemnt from module name - see rodjek/puppet-lint#252 6d2c7a0 Add SASL support 33c698b Added option "auto_removal" this option aim to enable or disable the -M option. 4a2d576 Merge pull request redhat-openstack#44 from hogepodge/relax_pe_requirement d6fe71b Merge pull request redhat-openstack#43 from ccin2p3/fix-ensure-absent 345bfc6 Releax the Puppet Enterprise requirement c76b78f Fix bug when `package_ensure` was set to `absent`. 4b29e75 Merge pull request redhat-openstack#41 from Mayflower/sles 64bb421 sles support 468742f fix metadata.json d1ca737 replace Modulefile with metadata.json 5a6c247 new release v2.5.0 55aef26 add parameter to disable service restart 3041b16 Merge pull request redhat-openstack#39 from fizmat/redhat_logging 5437c3a Merge pull request redhat-openstack#40 from misterdorm/template_to_s 2200af3 explicitly calling to_s on parameters that could potentially be a numeric type, to avoid ruby errors 6a55417 $logfile support for redhat 2f5cf83 Merge pull request redhat-openstack#38 from hdanes/master 64450b5 Enforce Linux line endings for *.erb templates. 6583748 update module version to 2.4.0 2b4c7bb Merge branch 'amazon' 6320354 Update module version to 2.3.0 3b4410c add support for Amazon Linux d266757 Merge pull request redhat-openstack#34 from ghoneycutt/add_firewall 9dc9231 Travis will check for syntax validation and style before specs bb9b752 Addressing simple style fixes 30b31d6 Resolving conflicts with upstream 35f17c2 Add support for Puppet v3.4 9f959da Add rake tasks for validation and linting e3bef50 Add ability to manage firewall e27b5b6 Manage firewall entries d009260 update README 8f42708 run puppet 2.6 only with 1.8.7 d089879 update gemfile ad67617 move travis build image in README bf2b751 add multiple rvm versions ce6f55b add more rvm versions 29b4065 more output on rake spec run fee24ce update module version 35413d2 improve spec tests 95b6a32 add processorcount variable a60da9a update module version 788c513 Merge pull request redhat-openstack#26 from red-trela/fix-remaining-deprecation-warnings 40df54d Fix remaining deprecation warnings 2c6f659 update module version 260cd78 ensure service is stopped, if package_ensure is set to absent 5be929b new module version e6917c8 fix travis file eae28e6 add ghpublisher to travis file 36a7d4b use braces around variables 5a399cc service has status command on some platforms 7adcc74 update module version 4af9523 ignore ghpublisher directory 9a7af54 remove puppet version 3.2.0 cec690b switch gem source fc51f0e add newer puppet versions to travis file 31db36e Merge branch 'master' of github.com:saz/puppet-memcached 3e05fa7 use double quotes instead of single quotes 7562abf Merge pull request redhat-openstack#23 from blkperl/fix_dep_warnings d552328 Fix Puppet 3.2.x deprecation warnings 7585134 Merge pull request redhat-openstack#20 from zylon-internet/master 0b300f8 Implement Override the default size of each slab page 51af7b0 Version 2.1.0 ea8b4d0 Merge pull request redhat-openstack#19 from tPl0ch/feature/dev-libs 571c2c3 New parameter '$install_dev' to install development headers.
xbezdick
added a commit
to xbezdick/openstack-puppet-modules
that referenced
this pull request
Dec 2, 2014
5869cad Merge pull request redhat-openstack#51 from jburnham/feature/pidfile-support 57fdf41 Merge pull request redhat-openstack#50 from joshuaspence/master 7066392 Add support for custom and disabling of pidfiles. 5973ec8 Add support for large memory pages b1c0011 new release v2.6.0 7b8ce2a Merge branch 'gloppasglop-feature_sasl' b1bcddd Merge branch 'feature_sasl' of https://github.com/gloppasglop/puppet-memcached into gloppasglop-feature_sasl 8c340fd Merge pull request redhat-openstack#49 from misterdorm/puppet37x 66fd812 Merge pull request redhat-openstack#46 from sxd/master e0c717f Replaced references to type() function with is_string() for Puppet 3.7.x, which now reserves the "type" keyword for future use. e368e33 Add relative option to puppet-lint - This is to avoid issue cause by the fact that - foloder name is differemnt from module name - see rodjek/puppet-lint#252 6d2c7a0 Add SASL support 33c698b Added option "auto_removal" this option aim to enable or disable the -M option. 4a2d576 Merge pull request redhat-openstack#44 from hogepodge/relax_pe_requirement d6fe71b Merge pull request redhat-openstack#43 from ccin2p3/fix-ensure-absent 345bfc6 Releax the Puppet Enterprise requirement c76b78f Fix bug when `package_ensure` was set to `absent`. 4b29e75 Merge pull request redhat-openstack#41 from Mayflower/sles 64bb421 sles support 468742f fix metadata.json d1ca737 replace Modulefile with metadata.json 5a6c247 new release v2.5.0 55aef26 add parameter to disable service restart 3041b16 Merge pull request redhat-openstack#39 from fizmat/redhat_logging 5437c3a Merge pull request redhat-openstack#40 from misterdorm/template_to_s 2200af3 explicitly calling to_s on parameters that could potentially be a numeric type, to avoid ruby errors 6a55417 $logfile support for redhat 2f5cf83 Merge pull request redhat-openstack#38 from hdanes/master 64450b5 Enforce Linux line endings for *.erb templates. 6583748 update module version to 2.4.0 2b4c7bb Merge branch 'amazon' 6320354 Update module version to 2.3.0 3b4410c add support for Amazon Linux d266757 Merge pull request redhat-openstack#34 from ghoneycutt/add_firewall 9dc9231 Travis will check for syntax validation and style before specs bb9b752 Addressing simple style fixes 30b31d6 Resolving conflicts with upstream 35f17c2 Add support for Puppet v3.4 9f959da Add rake tasks for validation and linting e3bef50 Add ability to manage firewall e27b5b6 Manage firewall entries d009260 update README 8f42708 run puppet 2.6 only with 1.8.7 d089879 update gemfile ad67617 move travis build image in README bf2b751 add multiple rvm versions ce6f55b add more rvm versions 29b4065 more output on rake spec run fee24ce update module version 35413d2 improve spec tests 95b6a32 add processorcount variable a60da9a update module version 788c513 Merge pull request redhat-openstack#26 from red-trela/fix-remaining-deprecation-warnings 40df54d Fix remaining deprecation warnings 2c6f659 update module version 260cd78 ensure service is stopped, if package_ensure is set to absent 5be929b new module version e6917c8 fix travis file eae28e6 add ghpublisher to travis file 36a7d4b use braces around variables 5a399cc service has status command on some platforms 7adcc74 update module version 4af9523 ignore ghpublisher directory 9a7af54 remove puppet version 3.2.0 cec690b switch gem source fc51f0e add newer puppet versions to travis file 31db36e Merge branch 'master' of github.com:saz/puppet-memcached 3e05fa7 use double quotes instead of single quotes 7562abf Merge pull request redhat-openstack#23 from blkperl/fix_dep_warnings d552328 Fix Puppet 3.2.x deprecation warnings 7585134 Merge pull request redhat-openstack#20 from zylon-internet/master 0b300f8 Implement Override the default size of each slab page 51af7b0 Version 2.1.0 ea8b4d0 Merge pull request redhat-openstack#19 from tPl0ch/feature/dev-libs 571c2c3 New parameter '$install_dev' to install development headers.
strider
added a commit
to strider/openstack-puppet-modules
that referenced
this pull request
Feb 19, 2015
5869cad Merge pull request redhat-openstack#51 from jburnham/feature/pidfile-support 57fdf41 Merge pull request redhat-openstack#50 from joshuaspence/master 7066392 Add support for custom and disabling of pidfiles. 5973ec8 Add support for large memory pages b1c0011 new release v2.6.0 7b8ce2a Merge branch 'gloppasglop-feature_sasl' b1bcddd Merge branch 'feature_sasl' of https://github.com/gloppasglop/puppet-memcached into gloppasglop-feature_sasl 8c340fd Merge pull request redhat-openstack#49 from misterdorm/puppet37x 66fd812 Merge pull request redhat-openstack#46 from sxd/master e0c717f Replaced references to type() function with is_string() for Puppet 3.7.x, which now reserves the "type" keyword for future use. e368e33 Add relative option to puppet-lint - This is to avoid issue cause by the fact that - foloder name is differemnt from module name - see rodjek/puppet-lint#252 6d2c7a0 Add SASL support 33c698b Added option "auto_removal" this option aim to enable or disable the -M option. 4a2d576 Merge pull request redhat-openstack#44 from hogepodge/relax_pe_requirement d6fe71b Merge pull request redhat-openstack#43 from ccin2p3/fix-ensure-absent 345bfc6 Releax the Puppet Enterprise requirement c76b78f Fix bug when `package_ensure` was set to `absent`. 4b29e75 Merge pull request redhat-openstack#41 from Mayflower/sles 64bb421 sles support 468742f fix metadata.json d1ca737 replace Modulefile with metadata.json 5a6c247 new release v2.5.0 55aef26 add parameter to disable service restart 3041b16 Merge pull request redhat-openstack#39 from fizmat/redhat_logging 5437c3a Merge pull request redhat-openstack#40 from misterdorm/template_to_s 2200af3 explicitly calling to_s on parameters that could potentially be a numeric type, to avoid ruby errors 6a55417 $logfile support for redhat 2f5cf83 Merge pull request redhat-openstack#38 from hdanes/master 64450b5 Enforce Linux line endings for *.erb templates. 6583748 update module version to 2.4.0 2b4c7bb Merge branch 'amazon' 6320354 Update module version to 2.3.0 3b4410c add support for Amazon Linux d266757 Merge pull request redhat-openstack#34 from ghoneycutt/add_firewall 9dc9231 Travis will check for syntax validation and style before specs bb9b752 Addressing simple style fixes 30b31d6 Resolving conflicts with upstream 35f17c2 Add support for Puppet v3.4 9f959da Add rake tasks for validation and linting e3bef50 Add ability to manage firewall e27b5b6 Manage firewall entries d009260 update README 8f42708 run puppet 2.6 only with 1.8.7 d089879 update gemfile ad67617 move travis build image in README bf2b751 add multiple rvm versions ce6f55b add more rvm versions 29b4065 more output on rake spec run fee24ce update module version 35413d2 improve spec tests 95b6a32 add processorcount variable a60da9a update module version 788c513 Merge pull request redhat-openstack#26 from red-trela/fix-remaining-deprecation-warnings 40df54d Fix remaining deprecation warnings 2c6f659 update module version 260cd78 ensure service is stopped, if package_ensure is set to absent 5be929b new module version e6917c8 fix travis file eae28e6 add ghpublisher to travis file 36a7d4b use braces around variables 5a399cc service has status command on some platforms 7adcc74 update module version 4af9523 ignore ghpublisher directory 9a7af54 remove puppet version 3.2.0 cec690b switch gem source fc51f0e add newer puppet versions to travis file 31db36e Merge branch 'master' of github.com:saz/puppet-memcached 3e05fa7 use double quotes instead of single quotes 7562abf Merge pull request redhat-openstack#23 from blkperl/fix_dep_warnings d552328 Fix Puppet 3.2.x deprecation warnings 7585134 Merge pull request redhat-openstack#20 from zylon-internet/master 0b300f8 Implement Override the default size of each slab page 51af7b0 Version 2.1.0 ea8b4d0 Merge pull request redhat-openstack#19 from tPl0ch/feature/dev-libs 571c2c3 New parameter '$install_dev' to install development headers. Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
xbezdick
added a commit
to xbezdick/openstack-puppet-modules
that referenced
this pull request
Feb 27, 2015
5869cad Merge pull request redhat-openstack#51 from jburnham/feature/pidfile-support 57fdf41 Merge pull request redhat-openstack#50 from joshuaspence/master 7066392 Add support for custom and disabling of pidfiles. 5973ec8 Add support for large memory pages b1c0011 new release v2.6.0 7b8ce2a Merge branch 'gloppasglop-feature_sasl' b1bcddd Merge branch 'feature_sasl' of https://github.com/gloppasglop/puppet-memcached into gloppasglop-feature_sasl 8c340fd Merge pull request redhat-openstack#49 from misterdorm/puppet37x 66fd812 Merge pull request redhat-openstack#46 from sxd/master e0c717f Replaced references to type() function with is_string() for Puppet 3.7.x, which now reserves the "type" keyword for future use. e368e33 Add relative option to puppet-lint - This is to avoid issue cause by the fact that - foloder name is differemnt from module name - see rodjek/puppet-lint#252 6d2c7a0 Add SASL support 33c698b Added option "auto_removal" this option aim to enable or disable the -M option. 4a2d576 Merge pull request redhat-openstack#44 from hogepodge/relax_pe_requirement d6fe71b Merge pull request redhat-openstack#43 from ccin2p3/fix-ensure-absent 345bfc6 Releax the Puppet Enterprise requirement c76b78f Fix bug when `package_ensure` was set to `absent`. 4b29e75 Merge pull request redhat-openstack#41 from Mayflower/sles 64bb421 sles support 468742f fix metadata.json d1ca737 replace Modulefile with metadata.json 5a6c247 new release v2.5.0 55aef26 add parameter to disable service restart 3041b16 Merge pull request redhat-openstack#39 from fizmat/redhat_logging 5437c3a Merge pull request redhat-openstack#40 from misterdorm/template_to_s 2200af3 explicitly calling to_s on parameters that could potentially be a numeric type, to avoid ruby errors 6a55417 $logfile support for redhat 2f5cf83 Merge pull request redhat-openstack#38 from hdanes/master 64450b5 Enforce Linux line endings for *.erb templates. 6583748 update module version to 2.4.0 2b4c7bb Merge branch 'amazon' 6320354 Update module version to 2.3.0 3b4410c add support for Amazon Linux d266757 Merge pull request redhat-openstack#34 from ghoneycutt/add_firewall 9dc9231 Travis will check for syntax validation and style before specs bb9b752 Addressing simple style fixes 30b31d6 Resolving conflicts with upstream 35f17c2 Add support for Puppet v3.4 9f959da Add rake tasks for validation and linting e3bef50 Add ability to manage firewall e27b5b6 Manage firewall entries d009260 update README 8f42708 run puppet 2.6 only with 1.8.7 d089879 update gemfile ad67617 move travis build image in README bf2b751 add multiple rvm versions ce6f55b add more rvm versions 29b4065 more output on rake spec run fee24ce update module version 35413d2 improve spec tests 95b6a32 add processorcount variable a60da9a update module version 788c513 Merge pull request redhat-openstack#26 from red-trela/fix-remaining-deprecation-warnings 40df54d Fix remaining deprecation warnings 2c6f659 update module version 260cd78 ensure service is stopped, if package_ensure is set to absent 5be929b new module version e6917c8 fix travis file eae28e6 add ghpublisher to travis file 36a7d4b use braces around variables 5a399cc service has status command on some platforms 7adcc74 update module version 4af9523 ignore ghpublisher directory 9a7af54 remove puppet version 3.2.0 cec690b switch gem source fc51f0e add newer puppet versions to travis file 31db36e Merge branch 'master' of github.com:saz/puppet-memcached 3e05fa7 use double quotes instead of single quotes 7562abf Merge pull request redhat-openstack#23 from blkperl/fix_dep_warnings d552328 Fix Puppet 3.2.x deprecation warnings 7585134 Merge pull request redhat-openstack#20 from zylon-internet/master 0b300f8 Implement Override the default size of each slab page 51af7b0 Version 2.1.0 ea8b4d0 Merge pull request redhat-openstack#19 from tPl0ch/feature/dev-libs 571c2c3 New parameter '$install_dev' to install development headers.
xbezdick
added a commit
to xbezdick/openstack-puppet-modules
that referenced
this pull request
Mar 3, 2015
5869cad Merge pull request redhat-openstack#51 from jburnham/feature/pidfile-support 57fdf41 Merge pull request redhat-openstack#50 from joshuaspence/master 7066392 Add support for custom and disabling of pidfiles. 5973ec8 Add support for large memory pages b1c0011 new release v2.6.0 7b8ce2a Merge branch 'gloppasglop-feature_sasl' b1bcddd Merge branch 'feature_sasl' of https://github.com/gloppasglop/puppet-memcached into gloppasglop-feature_sasl 8c340fd Merge pull request redhat-openstack#49 from misterdorm/puppet37x 66fd812 Merge pull request redhat-openstack#46 from sxd/master e0c717f Replaced references to type() function with is_string() for Puppet 3.7.x, which now reserves the "type" keyword for future use. e368e33 Add relative option to puppet-lint - This is to avoid issue cause by the fact that - foloder name is differemnt from module name - see rodjek/puppet-lint#252 6d2c7a0 Add SASL support 33c698b Added option "auto_removal" this option aim to enable or disable the -M option. 4a2d576 Merge pull request redhat-openstack#44 from hogepodge/relax_pe_requirement d6fe71b Merge pull request redhat-openstack#43 from ccin2p3/fix-ensure-absent 345bfc6 Releax the Puppet Enterprise requirement c76b78f Fix bug when `package_ensure` was set to `absent`. 4b29e75 Merge pull request redhat-openstack#41 from Mayflower/sles 64bb421 sles support 468742f fix metadata.json d1ca737 replace Modulefile with metadata.json 5a6c247 new release v2.5.0 55aef26 add parameter to disable service restart 3041b16 Merge pull request redhat-openstack#39 from fizmat/redhat_logging 5437c3a Merge pull request redhat-openstack#40 from misterdorm/template_to_s 2200af3 explicitly calling to_s on parameters that could potentially be a numeric type, to avoid ruby errors 6a55417 $logfile support for redhat 2f5cf83 Merge pull request redhat-openstack#38 from hdanes/master 64450b5 Enforce Linux line endings for *.erb templates. 6583748 update module version to 2.4.0 2b4c7bb Merge branch 'amazon' 6320354 Update module version to 2.3.0 3b4410c add support for Amazon Linux d266757 Merge pull request redhat-openstack#34 from ghoneycutt/add_firewall 9dc9231 Travis will check for syntax validation and style before specs bb9b752 Addressing simple style fixes 30b31d6 Resolving conflicts with upstream 35f17c2 Add support for Puppet v3.4 9f959da Add rake tasks for validation and linting e3bef50 Add ability to manage firewall e27b5b6 Manage firewall entries d009260 update README 8f42708 run puppet 2.6 only with 1.8.7 d089879 update gemfile ad67617 move travis build image in README bf2b751 add multiple rvm versions ce6f55b add more rvm versions 29b4065 more output on rake spec run fee24ce update module version 35413d2 improve spec tests 95b6a32 add processorcount variable a60da9a update module version 788c513 Merge pull request redhat-openstack#26 from red-trela/fix-remaining-deprecation-warnings 40df54d Fix remaining deprecation warnings 2c6f659 update module version 260cd78 ensure service is stopped, if package_ensure is set to absent 5be929b new module version e6917c8 fix travis file eae28e6 add ghpublisher to travis file 36a7d4b use braces around variables 5a399cc service has status command on some platforms 7adcc74 update module version 4af9523 ignore ghpublisher directory 9a7af54 remove puppet version 3.2.0 cec690b switch gem source fc51f0e add newer puppet versions to travis file 31db36e Merge branch 'master' of github.com:saz/puppet-memcached 3e05fa7 use double quotes instead of single quotes 7562abf Merge pull request redhat-openstack#23 from blkperl/fix_dep_warnings d552328 Fix Puppet 3.2.x deprecation warnings 7585134 Merge pull request redhat-openstack#20 from zylon-internet/master 0b300f8 Implement Override the default size of each slab page 51af7b0 Version 2.1.0 ea8b4d0 Merge pull request redhat-openstack#19 from tPl0ch/feature/dev-libs 571c2c3 New parameter '$install_dev' to install development headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This argument will cause the autoload layout class plugin to ignore the
top-most directory in the structure. This is useful for the common case where
the folder name is not the same as the module name in raw source code.
This should not modify default behavior of the tool.
This closes #245
Example
puppet-foo/manifests/init.pp
Without
--relative
With
--relative
This allows us to continue testing the general autoload layout if we purposely
compare relatively.