level_tokens[0] can be nil if there is no params in the top level block #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the case where a
{ }block can exist that has no=>in it, but blocks inside that block do (basically only for case statements).level_tokensgets initialised when the first=>is encountered in the block.This PR fixes this behaviour by checking if level_tokens[n] is nil and defaulting it to an empty array. Additionally, the behaviour of
PuppetLint::Data#resource_indexeswas inadvertently changed when I missed a call totypewhich resulted in comparing aPuppetLint::Lexer::Tokenobject to a symbol.Fixes #681