Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some specs that pass w/0.1.6 break in 1.0.1 #138

Closed
arusso opened this issue Dec 20, 2013 · 1 comment
Closed

some specs that pass w/0.1.6 break in 1.0.1 #138

arusso opened this issue Dec 20, 2013 · 1 comment
Milestone

Comments

@arusso
Copy link
Contributor

arusso commented Dec 20, 2013

Since upgrading to 1.0.1, some tests that used in 0.1.6 that don't pass now. Mostly, they appear to be related to tests of functions that pass either nil, :undef or '', but there's some tests do pass that pass one of those three parameters as the only parameter.

In addition (and possibly related), there's some error text being interwoven with the normal output indicating RSpec isn't happy with one of the matchers.

Here's an example:

Failures:

  1) format_action => Pass nil should When you call a matcher in an example without a String, like this:

specify { object.should matcher }

or this:

it { should matcher }

RSpec expects the matcher to have a #description method. You should either
add a String to the example this matcher is being used in, or give it a
description method. Then you won't have to suffer this lengthy warning again.
     Failure/Error: should run.with_params(nil).and_raise_error(Puppet::ParseError)
     ArgumentError:
       wrong number of arguments (0 for 1)
     # ./spec/functions/format_action_spec.rb:22

Here's the spec test itself:

describe 'format_action' do
  ...
  context '=> Pass nil' do
    it {
      should run.with_params(nil).and_raise_error(Puppet::ParseError)
    }
  end
  ...
end

Here's a gist with the entire rspec run output

@rodjek
Copy link
Owner

rodjek commented Jan 25, 2014

This should be fixed as a combination of #142 and c44381a

@rodjek rodjek closed this as completed Jan 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants