Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport units fixed in iOS8 #19

Closed
bratvanov opened this issue Sep 18, 2014 · 7 comments
Closed

Viewport units fixed in iOS8 #19

bratvanov opened this issue Sep 18, 2014 · 7 comments

Comments

@bratvanov
Copy link

I can confirm that viewport units are finally fixed in iOS 8 that was just released.

Maybe we can update the UA test to exclude iOS 8 and only load the buggyfill in <iOS7, as from what I can tell at the moment "isMobileSafari" targets all versions which isn't optimal?

For a reference:

This is the UA on my iPhone 4S running iOS 7.0.3 which I purposely haven't yet updated to iOS8:

Mozilla/5.0 (iPhone; CPU iPhone OS 7_0_3 like Mac OS X) 
AppleWebKit/537.51.1 (KHTML, like Gecko) Version/7.0 
Mobile/11B511 Safari/9537.53

And here is the UA of my iPad Air running iOS 8.0:

Mozilla/5.0 (iPad; CPU OS 8_0 like Mac OS X) 
AppleWebKit/600.1.4 (KHTML, like Gecko) Version/8.0 
Mobile/12A365 Safari/600.1.4
@rodneyrehm
Copy link
Owner

You're welcome to send a PR ;)

@bratvanov
Copy link
Author

Unfortunately writing efficient regular expressions isn't my strong suit, so I'd prefer if someone more knowledgeable was to help out. :)

@ImBobby
Copy link

ImBobby commented Sep 26, 2014

Hello, any updates on this one?

@rodneyrehm
Copy link
Owner

Anyone is welcome to send a PR (Pull Request).

@duranmla
Copy link

duranmla commented Oct 8, 2014

@blowback
Copy link

You're welcome to merge the PR, hint hint ;)

@rodneyrehm
Copy link
Owner

merged "manually", sorry… thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants