-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewport units fixed in iOS8 #19
Comments
You're welcome to send a PR ;) |
Unfortunately writing efficient regular expressions isn't my strong suit, so I'd prefer if someone more knowledgeable was to help out. :) |
Hello, any updates on this one? |
Anyone is welcome to send a PR (Pull Request). |
I made a PR, hope it helps: https://github.com/rodneyrehm/viewport-units-buggyfill/pull/23/files |
You're welcome to merge the PR, hint hint ;) |
merged "manually", sorry… thx! |
I can confirm that viewport units are finally fixed in iOS 8 that was just released.
Maybe we can update the UA test to exclude iOS 8 and only load the buggyfill in <iOS7, as from what I can tell at the moment "isMobileSafari" targets all versions which isn't optimal?
For a reference:
This is the UA on my iPhone 4S running iOS 7.0.3 which I purposely haven't yet updated to iOS8:
And here is the UA of my iPad Air running iOS 8.0:
The text was updated successfully, but these errors were encountered: