Adding UIWebView auto initialization of buggyfill. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UIWebView has the same issues as mobile safari when using viewport units. This change makes the regex that matches Mobile Safari more generic to match what UIWebViews report in iOS. Tested on iOS Simulator UIWebView, iOS Simulator Mobile Safari, iOS 7 Mobile Safari, and iOS Twitter Client UIWebView. UIWebView "Mozilla/5.0 (iPhone; CPU iPhone OS 7_1 like Mac OS X) AppleWebKit/537.51.2 (KHTML, like Gecko) Mobile/11D167" Mobile Safari "Mozilla/5.0 (iPhone; CPU iPhone OS 7_1 like Mac OS X) AppleWebKit/537.51.2 (KHTML, like Gecko) Version/7.0 Mobile/11D167 Safari/9537.53"
|
I wonder if that is specific enough. Wouldn't this expression be more specific? var is_safari_or_uiwebview = /(iPhone|iPod|iPad).*AppleWebKit/i.test(navigator.userAgent); |
|
That looks like a better and more accurate version. Updated. |
rodneyrehm
added a commit
that referenced
this pull request
Apr 16, 2014
Fixing browser detection to add UIWebView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIWebView has the same issues as Mobile Safari when using viewport
units. This change makes the regex that matches Mobile Safari more
generic to match what UIWebViews report in iOS.
Tested on:
Client UIWebView.
UIWebView User Agent
Mobile Safari User Agent