Implement All Launches #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
That was great! Can you please just fix the conflict?
Thank you very much @ludamillion
spec/spacex/launches_spec.rb
Outdated
| @@ -2,8 +2,11 @@ | |||
|
|
|||
| require 'spec_helper' | |||
|
|
|||
| RSpec.shared_examples 'Merah Putih' do | |||
There was a problem hiding this comment.
I guess this wasn't suppose to be here. 😃
There was a problem hiding this comment.
Hah, yes that was a left over. Fixing that and the Rubocop issues now.
- Add `all` method to `SPACEX::Launches` to query all launches endpoint - Update `SPACEX::BaseRequest` to handle a response body which is an array
ludamillion
force-pushed
the
add-all-launches
branch
from
12fe3f4
to
1c243bc
Compare
Pull Request Test Coverage Report for Build 41
💛 - Coveralls |
For some reason VCR was reporting that there weren't interactions recorded for certain API calls (ones that I hadn't touched). Temporarily turning the record mode to `:new_episodes` and re-recording seemed to have addressed the issue. This solution did however require updating the tests with re-recorded API calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allmethod toSPACEX::Launchesto query all launches endpointSPACEX::BaseRequestto handle a response body which is an array