Add the SPACEX::Launchpad class. #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 62
💛 - Coveralls |
invacuo
reviewed
Oct 12, 2018
There was a problem hiding this comment.
Hi @walerian777
Sorry for reviewing this only now. The last week was very busy here.
We're using .info and .info(x) on all methods. I'd follow the same pattern we're using in favor for compatibility. It is basically a proxy method that points to each one that you created when the parameter is presented or not.
Thank you very much!
Additionally, added corresponding specs and docs. Resolves #21.
|
Closing by inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, added corresponding specs and docs.
Resolves #21.