Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add payloads information #51

Merged
merged 10 commits into from
Oct 24, 2018
Merged

Add payloads information #51

merged 10 commits into from
Oct 24, 2018

Conversation

fernandomaia
Copy link
Contributor

  • Endpoint for payloads information
  • Small rubocop fix for history_spec file

Closes #49

@coveralls
Copy link

coveralls commented Oct 23, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 121

  • 58 of 58 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 117: 0.0%
Covered Lines: 854
Relevant Lines: 854
💛 - Coveralls

invacuo
invacuo reviewed Oct 23, 2018
View reviewed changes
Copy link
Collaborator

@invacuo invacuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

rodolfobandeira
rodolfobandeira reviewed Oct 23, 2018
View reviewed changes
Copy link
Owner

@rodolfobandeira rodolfobandeira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @maiaFernando
Just one small thing. Can you please add the payload links to the README index? (~line 37)

  - [Payloads](#payloads)
    - `SPACEX::Payloads.info`
    - `SPACEX::Payloads.info('payload_id')`

Other than that, looks pretty good!
Thanks again!

@fernandomaia
Copy link
Contributor Author

Whoops, I knew that I was missing something. Thanks @rodolfobandeira for pointing that out, already changed it.

@rodolfobandeira rodolfobandeira merged commit 7411de9 into rodolfobandeira:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invacuo invacuo invacuo left review comments

@rodolfobandeira rodolfobandeira rodolfobandeira approved these changes

Assignees

@fernandomaia fernandomaia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Payload Endpoint
4 participants
@fernandomaia @coveralls @rodolfobandeira @invacuo