Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ROOT_URI from version and use ENDPOINT_URI #54

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Remove ROOT_URI from version and use ENDPOINT_URI #54

merged 1 commit into from
Oct 25, 2018

Conversation

ludamillion
Copy link
Contributor

@ludamillion ludamillion commented Oct 24, 2018 •
edited
Loading

There was an unused SPACEX::ENDPOINT class constant which duplicated the data in the SPACEX::ROOT_URI constant in the version file. This changes the SPACEX::ENDPOINT class constant to SPACEX::ENDPOINT_URI and uses that in place of SPACEX::ROOT_URI.

In my experience the version file is not meant for 'business logic'. However, that it not s strongly held belief. If I'm the only one who thinks that we should instead remove the unused SPACEX::ENDPOINT class constant.

Remove ROOT_URI from version and use ENDPOINT_URI
c727089 
There was an unused ENDPOINT 'constant' which duplicated the data in the
ROOT_URI constant in the version file. The version file, at last IMO, is not
meant for 'business logic'. If I'm the only on who thinks that we should
instead remove the unused ENDPOINT class.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 126

  • 7 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 125: 0.0%
Covered Lines: 891
Relevant Lines: 891
💛 - Coveralls

@rodolfobandeira rodolfobandeira self-assigned this Oct 24, 2018
rodolfobandeira
rodolfobandeira approved these changes Oct 25, 2018
View reviewed changes
Copy link
Owner

@rodolfobandeira rodolfobandeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ludamillion
Thanks for submitting your pull request!

@rodolfobandeira rodolfobandeira merged commit 44b79ab into rodolfobandeira:master Oct 25, 2018
@rodolfobandeira
Copy link
Owner

rodolfobandeira commented Oct 25, 2018 •
edited
Loading

@ludamillion I'm gonna update the CHANGELOG.md with your name.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodolfobandeira rodolfobandeira rodolfobandeira approved these changes

Assignees

@rodolfobandeira rodolfobandeira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ludamillion @coveralls @rodolfobandeira