Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Upcoming Launches #56

Merged

Conversation

mtking2
Copy link
Contributor

@mtking2 mtking2 commented Oct 29, 2018

@coveralls
Copy link

coveralls commented Oct 29, 2018

Pull Request Test Coverage Report for Build 135

  • 72 of 72 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 132: 0.0%
Covered Lines: 963
Relevant Lines: 963

💛 - Coveralls

@rodolfobandeira
Copy link
Owner

@mtking2 Sorry but I ended merging PR #57 first. Can you please merge the latest master and fix the conflict?
Thanks again @mtking2

README.md Show resolved Hide resolved
spec/spacex/launches_spec.rb Show resolved Hide resolved
Copy link
Owner

@rodolfobandeira rodolfobandeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks @mtking2!

@rodolfobandeira rodolfobandeira merged commit 731910e into rodolfobandeira:master Nov 3, 2018
@mtking2 mtking2 mentioned this pull request Nov 4, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Remaining Launches Endpoints
4 participants