Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Info endpoint #69

Merged

Conversation

@fernandomaia
Copy link
Contributor

fernandomaia commented Oct 2, 2019

Why?

Description

@invacuo

This comment has been minimized.

Copy link
Collaborator

invacuo commented Oct 2, 2019

Hey @fernandomaia,

Thanks for the PR!

Looks like Travis is failing due to the same Faraday issue that I had to do in my PR #70 . You might have to do the same change in your PR or wait till my PR is merged in.

Cheers 🍻 !

Copy link
Collaborator

invacuo left a comment

Just a couple of minor comments. Else LGTM 👍

@@ -1,6 +1,7 @@
### 1.0.2 (next)

* Your contribution here.
* [#66](https://github.com/rodolfobandeira/spacex/pull/66): Implement API Info endpoint [@fernandomaia](https://github.com/fernandomaia).

This comment has been minimized.

Copy link
@invacuo

invacuo Oct 2, 2019

Collaborator

I think the numbers here should be your PR number and not the issue number. So this should be 69 instead of 66 in both the places.

subject do
SPACEX::ApiInfo.info
end
it 'returns API info' do

This comment has been minimized.

Copy link
@invacuo

invacuo Oct 2, 2019

Collaborator

Nit: A new line before it

@rodolfobandeira rodolfobandeira self-requested a review Oct 2, 2019
@fernandomaia

This comment has been minimized.

Copy link
Contributor Author

fernandomaia commented Oct 2, 2019

Hey @invacuo, thanks for your comments. Yeah, I had changed this manually but wasn't sure if it was a good idea to add it to this PR or if I should open up a new PR with this fix. Anyway, I'm going to fix up everything and then update this PR.

Thanks!

@rodolfobandeira rodolfobandeira merged commit 0e5c8ad into rodolfobandeira:master Oct 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.