Add API Info endpoint #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @fernandomaia, Thanks for the PR! Looks like Travis is failing due to the same Faraday issue that I had to do in my PR #70 . You might have to do the same change in your PR or wait till my PR is merged in. Cheers 🍻 ! |
invacuo
reviewed
Oct 2, 2019
CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| ### 1.0.2 (next) | |||
|
|
|||
| * Your contribution here. | |||
| * [#66](https://github.com/rodolfobandeira/spacex/pull/66): Implement API Info endpoint [@fernandomaia](https://github.com/fernandomaia). | |||
There was a problem hiding this comment.
I think the numbers here should be your PR number and not the issue number. So this should be 69 instead of 66 in both the places.
| subject do | ||
| SPACEX::ApiInfo.info | ||
| end | ||
| it 'returns API info' do |
|
Hey @invacuo, thanks for your comments. Yeah, I had changed this manually but wasn't sure if it was a good idea to add it to this PR or if I should open up a new PR with this fix. Anyway, I'm going to fix up everything and then update this PR. Thanks! |
rodolfobandeira
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Description