Update ruby version #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Why? Keeping the gem updated with the latest and greatest #### Description It works! 😄
| @@ -1 +1 @@ | |||
| 2.4.4 | |||
| 2.7.2 | |||
There was a problem hiding this comment.
Will this change made mandatory the use of ruby 2.7.2 for everyone using the gem?
There was a problem hiding this comment.
Did some reading on this. This file has no impact on the use of this gem. It is mainly for local development. We can specify a required_ruby_version in Gemspec which will impact everyone.
I noticed support for ruby 2.4. has ended, so thought I would upgrade the development requirement.
Debatable whether this PR is really needed 😄
rodolfobandeira
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Keeping the gem updated with the latest and greatest
Description
It works! 😄