Implement V4::Capsules #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SpaceX now has a v4 api and new [capsules endpoints](https://github.com/r-spacex/SpaceX-API/blob/master/docs/v4/README.md#capsules---schema) - Added code to support two of the new endpoints - Get all capsules - Get a specific capsule by id The README.md file was getting too long, so I created a docs folder and moved v3 and v4 documentation to their own markdown files
There was a problem hiding this comment.
@invacuo Just two comments. Sorry for the long time this PR was hanging here. Please let me know if you have some time to review my comments, otherwise I'll merge it and change some missing items myself. Example: Changelog, API version, and actually my PR comments.
Thanks!
|
@rodolfobandeira It has been a while since I opened these PRs. Let me try to remember what my thought process was and address your feedback. I also am curious to know your thoughts on the idea mentioned here #80 (comment) |
Merged
|
Thanks @invacuo We'll need to update the CHANGELOG.md. I can help with that right after I merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Description
Notes
The README.md file was getting too long, so I created a docs folder and moved v3 and v4 documentation to their own markdown files