Merge pull request #31 from rodrigo-arenas/0.6.Xdev

BaseSearchCV Partial Inheritance
rodrigo-arenas · Jun 23, 2021 · 2cccdc8 · 2cccdc8
2 parents d8d9ce4 + d5802bf
commit 2cccdc8
Show file tree

Hide file tree

Showing 6 changed files with 165 additions and 213 deletions.
diff --git a/docs/api/gasearchcv.rst b/docs/api/gasearchcv.rst
@@ -4,7 +4,6 @@ GASearchCV
 
 .. autoclass:: sklearn_genetic.GASearchCV
    :members:
-   :exclude-members: evaluate, mutate
-   :undoc-members: False
-
-
+   :inherited-members:
+   :exclude-members: evaluate, mutate, n_features_in_, classes_
+   :undoc-members: True
diff --git a/docs/conf.py b/docs/conf.py
@@ -39,7 +39,7 @@
     "sphinx.ext.autodoc",
     "sphinx.ext.autosummary",
     "numpydoc",
-    "sphinx.ext.napoleon",
+    # "sphinx.ext.napoleon",
     "sphinx.ext.mathjax",
     "sphinx.ext.viewcode",
     "sphinx_copybutton",

diff --git a/docs/release_notes.rst b/docs/release_notes.rst
@@ -16,6 +16,8 @@ Features:
   the iterations after a total (threshold) fitting time has been elapsed.
 * Now if one or more callbacks decides to stop the algorithm, it will print
   its class name to know which callbacks were responsible of the stopping.
+* Added support for extra methods coming from scikit-learn's BaseSearchCV, it is
+  still partial support, missing properties like `cv_results_`, `best_index_` and `multimetric_`.
 
 ^^^^^
 Docs:

diff --git a/sklearn_genetic/callbacks/early_stoppers.py b/sklearn_genetic/callbacks/early_stoppers.py
@@ -1,5 +1,4 @@
 from datetime import datetime
-import logging
 
 from .validations import check_stats
 from .base import BaseCallback