Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MACD indicator and also added to backtest for plotting #108

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

gunebakan
Copy link
Contributor

What have you changed and why?

MACD indicator file is added an plotted by adding a line to backtesting/main.go

Related Issues

Link related issues here.

@rodrigo-brito
Copy link
Owner

Closes #33

@codecov-commenter
Copy link

Codecov Report

Merging #108 (367a981) into main (dfe33ec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   49.88%   49.88%           
=======================================
  Files          15       15           
  Lines        2211     2211           
=======================================
  Hits         1103     1103           
  Misses       1045     1045           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe33ec...367a981. Read the comment docs.

@gunebakan gunebakan closed this Mar 15, 2022
@gunebakan gunebakan reopened this Mar 15, 2022
@rodrigo-brito
Copy link
Owner

Hi @gunebakan, great job!
I ajusted some visual details and include a warmup period for the data:
image

@rodrigo-brito rodrigo-brito merged commit 5bb2fda into rodrigo-brito:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants