Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/model:make more sense #246

Merged
merged 2 commits into from Mar 31, 2023
Merged

fix/model:make more sense #246

merged 2 commits into from Mar 31, 2023

Conversation

darrenli6
Copy link
Contributor

@darrenli6 darrenli6 commented Mar 28, 2023

What have you changed and why?

make more sense

Related Issues

Closes #245

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (181d220) 40.44% compared to head (4029b8b) 40.44%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   40.44%   40.44%           
=======================================
  Files          19       19           
  Lines        2893     2893           
=======================================
  Hits         1170     1170           
  Misses       1647     1647           
  Partials       76       76           
Impacted Files Coverage Δ
model/model.go 59.59% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

model/model_test.go Outdated Show resolved Hide resolved
@rodrigo-brito rodrigo-brito merged commit e6f2747 into rodrigo-brito:main Mar 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I think it would be better.
3 participants