Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(paperwallet): fix panic when asset is zero #265

Merged
merged 1 commit into from May 10, 2023

Conversation

daydoing
Copy link
Contributor

@daydoing daydoing commented May 9, 2023

What have you changed and why?

In backtesting, a panic occurs when the strategy has no trades.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (13d871e) 40.44% compared to head (782dbdd) 40.40%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   40.44%   40.40%   -0.05%     
==========================================
  Files          19       19              
  Lines        2893     2896       +3     
==========================================
  Hits         1170     1170              
- Misses       1647     1650       +3     
  Partials       76       76              
Impacted Files Coverage Δ
exchange/paperwallet.go 68.59% <0.00%> (-0.40%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rodrigo-brito
Copy link
Owner

Hi @daydoing, thank you for the contribution!

@rodrigo-brito rodrigo-brito merged commit ad885c7 into rodrigo-brito:main May 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants