-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backtesting) include button to export csv #86
feat(backtesting) include button to export csv #86
Conversation
…ninjabot into add-download-history-backtest
Codecov Report
@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 50.07% 50.15% +0.08%
==========================================
Files 14 15 +1
Lines 1909 2199 +290
==========================================
+ Hits 956 1103 +147
- Misses 895 1033 +138
- Partials 58 63 +5
Continue to review full report at Codecov.
|
Hi @panapol-p, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments.
Co-authored-by: Rodrigo Brito <7620947+rodrigo-brito@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @panapol-p, great job! 👏🏻👏🏻👏🏻
Just a small comment.
…nto add-download-history-backtest
Hi, I have some questions. |
Hi @panapol-p, don't worry about the coverage. I try to improve it later. Your code is well tested. |
Thanks @panapol-p, great job! |
What did not work before?
Include button to export CSV with orders in chart page #53
What have you changed and why?
add button for download trading history
add new api to get trading history by pair
This PR has: