fix: Error when sending any character that is not a number in limit o…

…r page
rodrigorahman · Dec 6, 2023 · 89569b4 · 89569b4
1 parent 9c3cbaa
commit 89569b4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/lib/src/server/handlers/get_handler.dart b/lib/src/server/handlers/get_handler.dart
@@ -120,8 +120,10 @@ class GetHandler {
       tableData = _filterData(tableData, params, headers);
     }
 
-    final page = int.parse(queryParameters['page'] ?? '1') - 1;
-    final limit = int.parse(queryParameters['limit'] ?? '10');
+    final pageParam = int.tryParse(queryParameters['page'] ?? '1') ?? 1;
+
+    final page = pageParam - 1;
+    final limit = int.tryParse(queryParameters['limit'] ?? '10') ?? 10;
     final totalList = tableData.length;
 
     var start = 0;

diff --git a/test/server/handlers/get_handler_test.dart b/test/server/handlers/get_handler_test.dart
@@ -24,6 +24,18 @@ void main() {
 
       final data = response.data as List;
 
+      expect(data.isNotEmpty, isTrue);
+      expect(data.length, greaterThan(1));
+      expect(data.length, lessThan(11));
+    });
+
+     test('should find users when sending any character that is not a number', () async {
+      final response =
+          await Dio().get('http://localhost:8080/users?page=A&limit=Q');
+
+      final data = response.data as List;
+
+
       expect(data.isNotEmpty, isTrue);
       expect(data.length, greaterThan(1));
       expect(data.length, lessThan(11));