Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox Column (showSelect: false) #31

Closed
xxJeevesxx opened this issue Apr 15, 2021 · 8 comments
Closed

Checkbox Column (showSelect: false) #31

xxJeevesxx opened this issue Apr 15, 2021 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@xxJeevesxx
Copy link

xxJeevesxx commented Apr 15, 2021

Love the package, thanks for creating it! I'm trying to remove the checkbox column.I try to disable the checkbox something I didn't expect happens. I see that showSelect maps to showCheckboxColumn in your implementation however it also removes the header along the top and the checkbox column doesn't actually disappear. Am I just missing something? I haven't played with the Flutter DataTable yet so maybe it happens there too. Any thoughts?

Before:
image

After (showSelect: false):
image

Edit: spelling

@rodydavis
Copy link
Owner

Ok that’s weird, I thought I fixed that! I’ll double check today 👍🏼

@rodydavis rodydavis self-assigned this Apr 15, 2021
@rodydavis rodydavis added the bug Something isn't working label Apr 15, 2021
@rodydavis
Copy link
Owner

Did you check with the latest?

@xxJeevesxx
Copy link
Author

I was hoping I could figure it out on my own but alas I wasn't sure.

I'm using 1.3.2 in pubspec.
image

@rodydavis
Copy link
Owner

Ok I think it is a bug 👍🏼

@rodydavis
Copy link
Owner

For the DataRow you need to also remove:

  onSelectChanged: (bool value) {
                if (dessert.selected != value) {
                  setState(() {
                    dessert.selected = value;
                  });
                }
              },

@xxJeevesxx
Copy link
Author

Ah, I see it now, thanks. Bummer though, I was hoping to be able to have an onTap like function for the row without having the checkbox. Any thoughts on that? Maybe I’ll have to figure that out on my own :).

@xxJeevesxx
Copy link
Author

Thanks again for your help and quick response. :)

@rodydavis
Copy link
Owner

rodydavis commented Apr 16, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants